Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(infra): Fix run-local-env services argument #16399

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

svanaeinars
Copy link
Member

@svanaeinars svanaeinars commented Oct 15, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced the run-local-env command with a detailed description and improved error handling for service inputs.
  • Bug Fixes

    • Improved validation for the services argument to ensure users provide necessary inputs.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@svanaeinars svanaeinars requested a review from a team as a code owner October 15, 2024 12:21
Copy link
Contributor

coderabbitai bot commented Oct 15, 2024

Walkthrough

The pull request modifies the command definitions in the CLI application, specifically updating the run-local-env command. The command's signature has been changed to include a positional argument [services...], and the validation mechanism has been enhanced by replacing demandCommand with a custom check method that throws an error if no services are provided. Other command options remain unchanged.

Changes

File Change Summary
infra/src/cli/cli.ts Updated run-local-env command signature to include [services...] and changed validation from demandCommand to check for improved error handling.

Possibly related PRs


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 8f7fe79 and 0d287b4.

📒 Files selected for processing (1)
  • infra/src/cli/cli.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • infra/src/cli/cli.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@svanaeinars svanaeinars added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Oct 15, 2024
Copy link
Member

@AndesKrrrrrrrrrrr AndesKrrrrrrrrrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

infra/src/cli/cli.ts Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.71%. Comparing base (420313d) to head (62b005c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16399      +/-   ##
==========================================
- Coverage   36.73%   36.71%   -0.03%     
==========================================
  Files        6809     6809              
  Lines      141086   141193     +107     
  Branches    40224    40214      -10     
==========================================
+ Hits        51825    51835      +10     
- Misses      89261    89358      +97     
Flag Coverage Δ
api 3.37% <ø> (ø)
application-system-api 41.42% <ø> (ø)
application-template-api-modules 27.89% <ø> (ø)
application-ui-shell 21.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 420313d...62b005c. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

All test runs 93bcaf7 🔗

10 Total Test Services: 0 Failed, 9 Passed
➡️ Test Sessions change in coverage: 27 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 2.91s 1 no change Link
api-domains-auth-admin 0 0 0 18 0 13.8s 1 no change Link
api-domains-communications 0 0 0 5 0 33.06s 1 no change Link
api-domains-license-service 0 0 0 0 0 588.31ms 1 no change Link
application-system-api 0 0 0 120 2 3m 29.55s 1 no change Link
application-template-api-modules 0 0 0 123 0 2m 32.89s 1 no change Link
cms-translations 0 0 0 3 0 30.86s 1 no change Link
judicial-system-api 0 0 0 57 0 6.83s 1 no change Link
judicial-system-backend 0 0 0 20997 0 20m 11.27s 1 no change Link
services-user-notification 0 0 0 51 0 1m 33.15s 1 no change Link

@kodiakhq kodiakhq bot merged commit e3e51fc into main Oct 15, 2024
47 checks passed
@kodiakhq kodiakhq bot deleted the chore/fix-run-local-env-arguments branch October 15, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated:automerge (Disabled) Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants