Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signature-collection): A litany of fixes #16415

Merged
merged 7 commits into from
Oct 16, 2024

Conversation

kksteini
Copy link
Member

@kksteini kksteini commented Oct 16, 2024

The parliamentary elections are on route for tomorrow at 13:00.
A cavalcade of commits follows:

albinagu and others added 6 commits October 16, 2024 09:36
* draft

* chore: nx format:write update dirty files

* fix: company path

* tweaks

* p

* view list company path

* chore: nx format:write update dirty files

* nav tweak

---------

Co-authored-by: andes-it <builders@andes.is>
Co-authored-by: Ásdís Erna Guðmundsdóttir <disa.erna@gmail.com>
* fix(service-portal): sp list submitted

* tweak

* chore: nx format:write update dirty files

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: andes-it <builders@andes.is>
* fix(portals-admin): adding report date

* chore: nx format:write update dirty files

* tweak

* tweak supervisors info

* chore: nx format:write update dirty files

* tweak

* message - company card

* tweak

* t

* t

* chore: nx format:write update dirty files

---------

Co-authored-by: andes-it <builders@andes.is>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* tweaka

* chore: nx format:write update dirty files

---------

Co-authored-by: andes-it <builders@andes.is>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* Tweaks for parliamentary collection

* revertt'

* Update libs/api/domains/signature-collection/src/lib/signatureCollection.service.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* managers should see other managers

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@kksteini kksteini requested review from a team as code owners October 16, 2024 09:41
@kksteini kksteini changed the title Hotfix/r32 1 0 democrazy haha get it fix(signature-collection): A litany of fixes Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 36.87%. Comparing base (855831b) to head (ae6e741).
Report is 3 commits behind head on release/32.1.0.

Files with missing lines Patch % Lines
...collection/src/lib/signature-collection.service.ts 0.00% 4 Missing ⚠️
...ion/src/lib/signature-collection-shared.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release/32.1.0   #16415   +/-   ##
===============================================
  Coverage           36.87%   36.87%           
===============================================
  Files                6801     6801           
  Lines              140594   140593    -1     
  Branches            39975    39974    -1     
===============================================
  Hits                51842    51842           
+ Misses              88752    88751    -1     
Flag Coverage Δ
api 3.37% <ø> (ø)
application-system-api 41.66% <0.00%> (+<0.01%) ⬆️
application-template-api-modules 24.30% <ø> (ø)
application-ui-shell 21.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
libs/service-portal/core/src/lib/messages.ts 50.00% <ø> (ø)
...s/service-portal/information/src/lib/navigation.ts 0.00% <ø> (ø)
...ion/src/lib/signature-collection-shared.service.ts 9.83% <0.00%> (+0.31%) ⬆️
...collection/src/lib/signature-collection.service.ts 6.94% <0.00%> (-0.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855831b...ae6e741. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Oct 16, 2024

Datadog Report

All test runs e3fbdc4 🔗

6 Total Test Services: 0 Failed, 5 Passed
🔻 Test Sessions change in coverage: 2 decreased, 31 no change

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 2.71s 1 no change Link
application-system-api 0 0 0 120 2 3m 16.17s 1 no change Link
application-template-api-modules 0 0 0 134 0 2m 7.07s 1 decreased (-4.08%) Link
application-ui-shell 0 0 0 74 0 36.24s 1 decreased (-0.13%) Link
service-portal-core 0 0 0 5 0 1.88s N/A Link
service-portal-health 0 0 0 0 0 543.45ms 1 no change Link

🔻 Code Coverage Decreases vs Default Branch (2)

  • application-template-api-modules - jest 26.02% (-4.08%) - Details
  • application-ui-shell - jest 27.88% (-0.13%) - Details

* tweaks

* tweak - create list

* copylink

* chore: nx format:write update dirty files

---------

Co-authored-by: andes-it <builders@andes.is>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@kksteini kksteini added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Oct 16, 2024
@kodiakhq kodiakhq bot merged commit 4ed03ad into release/32.1.0 Oct 16, 2024
55 checks passed
@kodiakhq kodiakhq bot deleted the hotfix/r32-1-0-democrazy-haha-get-it branch October 16, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated:automerge (Disabled) Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants