Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(application-plc): Fixes 16.10 batch 2 #16436

Merged
merged 3 commits into from
Oct 16, 2024
Merged

fix(application-plc): Fixes 16.10 batch 2 #16436

merged 3 commits into from
Oct 16, 2024

Conversation

kksteini
Copy link
Member

d25d4e9 (detect user delegation type)
8b46f97 (user not found handling)
695edee (refetch is owner 16.10)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

kksteini and others added 3 commits October 16, 2024 16:55
@kksteini
fix(application-plc): Detect user delegation type (#16429)
eb0dd47 
* wip

* wip

* Small fixes

* Conditioned

* Fixed messages

* Fixed conditionals
@alexdiljar @andes-it
@kodiakhq @kksteini
feat(signature-collection): user not found handling (#16431)
c612914 
* feat(signature=collection): user not found handling

* fix: text update

* chore: nx format:write update dirty files

---------

Co-authored-by: andes-it <builders@andes.is>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@albinagu @kodiakhq @kksteini
fix(signature-collection): refetch is owner 16.10 (#16432)
b9dcef3 
* fix(signature-collection): refetch is owner after remove last list

* tw

* tweak

* tw

* tw

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@kksteini kksteini requested review from a team as code owners October 16, 2024 16:56
@kksteini kksteini added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Oct 16, 2024
@albinagu albinagu removed the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Oct 16, 2024
alexdiljar
alexdiljar approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@alexdiljar alexdiljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

HjorturJ
HjorturJ approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@HjorturJ HjorturJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 6.66667% with 56 lines in your changes missing coverage. Please review.

Project coverage is 36.85%. Comparing base (9452ddc) to head (b9dcef3).
Report is 1 commits behind head on release/32.1.0.

Files with missing lines Patch % Lines
...list-signing/parliamentary-list-signing.service.ts 0.00% 26 Missing ⚠️
...collection/src/lib/signature-collection.service.ts 7.40% 25 Missing ⚠️
...st-creation/parliamentary-list-creation.service.ts 16.66% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/32.1.0   #16436      +/-   ##
==================================================
- Coverage           36.85%   36.85%   -0.01%     
==================================================
  Files                6802     6802              
  Lines              140662   140676      +14     
  Branches            39993    39996       +3     
==================================================
+ Hits                51847    51849       +2     
- Misses              88815    88827      +12
Flag Coverage Δ
api 3.37% <ø> (ø)
application-api-files 57.97% <ø> (ø)
application-core 71.62% <ø> (ø)
application-system-api 41.65% <6.66%> (-0.01%) ⬇️
application-template-api-modules 24.28% <0.00%> (-0.02%) ⬇️
application-templates-accident-notification 29.44% <ø> (ø)
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-criminal-record 26.63% <ø> (ø)
application-templates-driving-license 18.40% <ø> (ø)
application-templates-estate 12.32% <ø> (ø)
application-templates-example-payment 25.41% <ø> (ø)
application-templates-financial-aid 14.34% <ø> (ø)
application-templates-general-petition 23.68% <ø> (ø)
application-templates-health-insurance 26.62% <ø> (ø)
application-templates-inheritance-report 6.45% <ø> (ø)
application-templates-marriage-conditions 15.23% <ø> (ø)
application-templates-mortgage-certificate 43.96% <ø> (ø)
application-templates-parental-leave 30.03% <ø> (ø)
application-ui-components 1.28% <ø> (ø)
application-ui-shell 21.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
libs/application/core/src/lib/fieldBuilders.ts 37.98% <ø> (ø)
...iamentary-list-creation/src/dataProviders/index.ts 100.00% <100.00%> (ø)
...-list-creation/src/lib/createCollectionTemplate.ts 50.00% <ø> (ø)
...on/parliamentary-list-creation/src/lib/messages.ts 100.00% <ø> (ø)
...ction/parliamentary-list-signing/src/lib/errors.ts 100.00% <ø> (ø)
...st-creation/parliamentary-list-creation.service.ts 27.94% <16.66%> (-1.10%) ⬇️
...collection/src/lib/signature-collection.service.ts 6.69% <7.40%> (-0.10%) ⬇️
...list-signing/parliamentary-list-signing.service.ts 14.51% <0.00%> (-1.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9452ddc...b9dcef3. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

All test runs ab1de01 🔗

✅ 17 Total Test Services: 0 Failed, 17 Passed
🔻 Test Sessions change in coverage: 4 decreased, 18 increased, 65 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 2.96s 1 no change Link
application-api-files 0 0 0 12 0 6.91s 1 decreased (-0.05%) Link
application-core 0 0 0 90 0 22.1s 1 decreased (-0.2%) Link
application-system-api 0 0 0 120 2 3m 47.14s 1 increased (+0.05%) Link
application-template-api-modules 0 0 0 134 0 2m 8.02s 1 decreased (-4.08%) Link
application-templates-accident-notification 0 0 0 148 0 22.35s 1 increased (+0.24%) Link
application-templates-criminal-record 0 0 0 2 0 13.17s 1 increased (+0.48%) Link
application-templates-driving-license 0 0 0 13 0 17.64s 1 increased (+0.22%) Link
application-templates-example-payment 0 0 0 2 0 12.6s 1 increased (+0.47%) Link
application-templates-financial-aid 0 0 0 11 0 16.79s 1 increased (+0.11%) Link

🔻 Code Coverage Decreases vs Default Branch (4)

  • application-template-api-modules - jest 26.01% (-4.08%) - Details
  • application-core - jest 79.57% (-0.2%) - Details
  • application-ui-shell - jest 27.88% (-0.13%) - Details
  • application-api-files - jest 61.85% (-0.05%) - Details

@kksteini kksteini added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Oct 16, 2024
@kodiakhq kodiakhq bot merged commit d2b6984 into release/32.1.0 Oct 16, 2024
96 checks passed
@kodiakhq kodiakhq bot deleted the hotfix/r32-1-0-parliamentary-list-creation-fixes-16-10-batch-2 branch October 16, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdiljar alexdiljar alexdiljar approved these changes

@HjorturJ HjorturJ HjorturJ approved these changes

Assignees
No one assigned
Labels
deprecated:automerge (Disabled) Merge this PR as soon as all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kksteini @HjorturJ @alexdiljar @albinagu