Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(my-pages): hotfix for subpoenas #16576

Merged
merged 4 commits into from
Oct 25, 2024
Merged

fix(my-pages): hotfix for subpoenas #16576

merged 4 commits into from
Oct 25, 2024

Conversation

disaerna
Copy link
Member

@disaerna disaerna commented Oct 25, 2024 •
edited
Loading

Hotfix for subpoenas 🔥

#16554 Prod Path for RVG
#16506 Better error handling
#16219 Filtering documents
#16572 Display error message on dashboard for urgent documents

Why

Subpoenas and law and order module going live on next Monday !! 🥳

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

disaerna and others added 3 commits October 25, 2024 15:43
@disaerna @kodiakhq
fix(clients): prod path (#16554)
6cf2747 
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@disaerna @kodiakhq
fix(my-pages): Law and Order - error handling (#16506)
945f856 
* fix: remove button if error

* feat: audit and log error if lawyer list fails

* feat: detailed logs

* fix: remove noice

* revert message prop

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@disaerna @kodiakhq
fix(service-portal): Filtering mailbox documents (#16219)
567e940 
* fix: health delegation bug and move logic to service

* feat: hide law and order and health data if certain delegation

* console

* fix: add correct id

* remove birthday use (v1 is deprecated)

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 25, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@disaerna @kodiakhq
fix(my-pages): display error message on urgent files on dashboard (#1…
117b7f6 
…6572)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@disaerna disaerna added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Oct 25, 2024
@disaerna disaerna marked this pull request as ready for review October 25, 2024 16:22
@disaerna disaerna requested review from a team as code owners October 25, 2024 16:22
eirikurn
eirikurn approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@eirikurn eirikurn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving core files

@codecov Codecov
Copy link

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.76%. Comparing base (a2327d4) to head (117b7f6).
Report is 1 commits behind head on release/32.2.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/32.2.0   #16576      +/-   ##
==================================================
- Coverage           36.77%   36.76%   -0.02%     
==================================================
  Files                6847     6847              
  Lines              141873   141869       -4     
  Branches            40423    40422       -1     
==================================================
- Hits                52168    52152      -16     
- Misses              89705    89717      +12
Flag Coverage Δ
api 3.37% <ø> (ø)
application-api-files 56.86% <ø> (ø)
application-system-api 41.34% <ø> (ø)
application-template-api-modules 27.79% <ø> (-0.02%) ⬇️
application-templates-accident-notification 29.27% <ø> (ø)
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-driving-license 18.34% <ø> (ø)
application-templates-estate 12.32% <ø> (+<0.01%) ⬆️
application-templates-financial-aid 15.49% <ø> (ø)
application-templates-general-petition 23.44% <ø> (ø)
application-templates-inheritance-report 6.49% <ø> (ø)
application-templates-marriage-conditions 15.17% <ø> (ø)
application-templates-mortgage-certificate 43.82% <ø> (ø)
application-templates-parental-leave 29.96% <ø> (-0.08%) ⬇️
application-ui-components 1.28% <ø> (ø)
application-ui-shell 21.38% <ø> (+0.02%) ⬆️
auth-react 22.44% <ø> (-0.34%) ⬇️
portals-admin-regulations-admin 1.85% <ø> (ø)
portals-core 16.17% <ø> (+0.01%) ⬆️
shared-components 27.71% <ø> (+0.06%) ⬆️
shared-form-fields 31.60% <ø> (ø)
web 1.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
libs/auth/react/src/lib/auth/Auth.state.ts 54.54% <ø> (-7.00%) ⬇️
...al/graphql/src/hooks/documents/useListDocuments.ts 14.28% <ø> (ø)

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2327d4...117b7f6. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

All test runs b736d24 🔗

✅ 23 Total Test Services: 0 Failed, 21 Passed
🔻 Test Sessions change in coverage: 1 decreased (-0.02%), 2 increased, 104 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 2.63s 1 no change Link
application-api-files 0 0 0 12 0 6.3s 1 increased (+0.04%) Link
application-system-api 0 0 0 120 2 3m 15.72s 1 no change Link
application-template-api-modules 0 0 0 123 0 2m 25.35s 1 decreased (-0.02%) Link
application-templates-accident-notification 0 0 0 148 0 17.87s 1 no change Link
application-templates-driving-license 0 0 0 13 0 14.65s 1 no change Link
application-templates-financial-aid 0 0 0 11 0 14.23s 1 no change Link
application-templates-general-petition 0 0 0 5 0 10.88s 1 no change Link
application-templates-health-insurance 0 0 0 0 0 505.72ms 1 no change Link
application-templates-mortgage-certificate 0 0 0 3 0 21.66s 1 increased (+0.28%) Link

🔻 Code Coverage Decreases vs Default Branch (1)

  • application-template-api-modules - jest 30.04% (-0.02%) - Details

@kodiakhq kodiakhq bot merged commit 7a5a851 into release/32.2.0 Oct 25, 2024
107 checks passed
@kodiakhq kodiakhq bot deleted the hotfix/error-handling-and-filtering branch October 25, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eirikurn eirikurn eirikurn approved these changes

@thorkellmani thorkellmani thorkellmani approved these changes

@peturgq peturgq peturgq approved these changes

Assignees
No one assigned
Labels
deprecated:automerge (Disabled) Merge this PR as soon as all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@disaerna @eirikurn @thorkellmani @peturgq