Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-app): fix normal document loading #16589

Merged
merged 2 commits into from
Oct 28, 2024
Merged

fix(native-app): fix normal document loading #16589

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07ddce5
fix: reverting scroll fix
thoreyjona Oct 28, 2024
1e20f4b
Merge branch 'main' into fix/fix-document-loading
kodiakhq[bot] Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions apps/native/app/src/screens/document-detail/document-detail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,6 @@ export const DocumentDetailScreen: NavigationFunctionComponent<{
} finally {
markDocumentAsRead()
setRefetching(false)
setLoaded(true)
}
}

Expand Down Expand Up @@ -487,17 +486,13 @@ export const DocumentDetailScreen: NavigationFunctionComponent<{
/>
) : hasPdf ? (
<PdfWrapper>
{visible && accessToken && loaded && (
{visible && accessToken && (
<PdfViewer
url={`data:application/pdf;base64,${Document.content?.value}`}
body={`documentId=${Document.id}&__accessToken=${accessToken}`}
onLoaded={(filePath: any) => {
setPdfUrl(filePath)
// Make sure to not set document as loaded until actions have been fetched
// To prevent top of first page not being shown
if (shouldIncludeDocument) {
setLoaded(true)
}
setLoaded(true)
}}
onError={() => {
setLoaded(true)
Expand Down