feat(ojoi): PDF generation #16698
feat(ojoi): PDF generation #16698
Conversation
WalkthroughThis pull request introduces a new GraphQL query method Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 10
🧹 Outside diff range and nitpick comments (5)
libs/api/domains/official-journal-of-iceland-application/src/models/getPdf.response.ts (1)
1-7: LGTM! Consider enhancing documentation and type safety.The implementation is clean and follows GraphQL/NestJS best practices. The explicit naming with 'OJOIA' prefix helps prevent naming collisions.
Consider these enhancements for better documentation and type safety:
@ObjectType('OJOIAGetPdfResponse') export class GetPdfResponse { - @Field() + @Field(() => String, { + description: 'Base64 encoded PDF content for the official journal advertisement' + }) pdf!: string }libs/clients/official-journal-of-iceland/application/src/lib/ojoiApplicationClient.service.ts (1)
101-111: Consider adding response validationThe implementation looks good and follows the service's error handling pattern. However, consider adding response validation to ensure the PDF data is present before returning.
Consider adding validation:
async getPdf( params: GetPdfByApplicationIdRequest, auth: Auth, ): Promise<GetPdfRespone> { try { - return this.ojoiApplicationApiWithAuth(auth).getPdfByApplicationId(params) + const response = await this.ojoiApplicationApiWithAuth(auth).getPdfByApplicationId(params) + if (!response?.pdf) { + throw new Error('PDF data is missing in the response') + } + return response } catch (error) { this.logger.warn('Failed to get pdf', { applicationId: params.id, error, category: LOG_CATEGORY, }) throw error } }libs/api/domains/official-journal-of-iceland-application/src/lib/ojoiApplication.resolver.ts (1)
75-80: Add tests for the new getPdf query.As mentioned in the PR objectives, tests are missing. Please add unit tests to cover:
- Successful PDF retrieval
- Error scenarios
- Authentication/authorization checks
Would you like me to help create a test suite for this new functionality?
libs/application/templates/official-journal-of-iceland/src/graphql/queries.ts (1)
319-326: Consider adding TypeScript type definitions and documentation.The query implementation looks good and aligns with the existing patterns. However, to improve maintainability and type safety:
- Consider adding TypeScript type definitions for the query response:
export interface GetPdfResponse { OJOIAGetPdf: { pdf: string; } }
- Add JSDoc comments to document the query's purpose and expected input/output:
/** * Fetches a PDF document for an Official Journal of Iceland application * @param input - The application ID input * @returns The PDF content as a base64 string */libs/clients/official-journal-of-iceland/application/src/clientConfig.json (1)
1231-1231: Add format validation for base64 encoded PDF contentThe
contentfield should specify the format as base64 to ensure proper validation.Apply this diff to add format validation:
- "content": { "type": "string", "description": "Base64 encoded PDF" } + "content": { + "type": "string", + "format": "base64", + "description": "Base64 encoded PDF", + "contentMediaType": "application/pdf" + }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (10)
libs/api/domains/official-journal-of-iceland-application/src/lib/ojoiApplication.resolver.ts(2 hunks)libs/api/domains/official-journal-of-iceland-application/src/lib/ojoiApplication.service.ts(2 hunks)libs/api/domains/official-journal-of-iceland-application/src/models/getPdf.response.ts(1 hunks)libs/application/templates/official-journal-of-iceland/src/fields/Preview.tsx(6 hunks)libs/application/templates/official-journal-of-iceland/src/graphql/queries.ts(1 hunks)libs/application/templates/official-journal-of-iceland/src/hooks/usePdf.ts(1 hunks)libs/application/templates/official-journal-of-iceland/src/lib/messages/preview.ts(1 hunks)libs/application/templates/official-journal-of-iceland/src/lib/utils.ts(1 hunks)libs/clients/official-journal-of-iceland/application/src/clientConfig.json(7 hunks)libs/clients/official-journal-of-iceland/application/src/lib/ojoiApplicationClient.service.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (10)
libs/api/domains/official-journal-of-iceland-application/src/lib/ojoiApplication.resolver.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/api/domains/official-journal-of-iceland-application/src/lib/ojoiApplication.service.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/api/domains/official-journal-of-iceland-application/src/models/getPdf.response.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/official-journal-of-iceland/src/fields/Preview.tsx (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/official-journal-of-iceland/src/graphql/queries.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/official-journal-of-iceland/src/hooks/usePdf.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/official-journal-of-iceland/src/lib/messages/preview.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/official-journal-of-iceland/src/lib/utils.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/clients/official-journal-of-iceland/application/src/clientConfig.json (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/clients/official-journal-of-iceland/application/src/lib/ojoiApplicationClient.service.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
🔇 Additional comments (14)
libs/api/domains/official-journal-of-iceland-application/src/models/getPdf.response.ts (1)
6-6: Verify PDF content handling.
The pdf field is marked as a required string, but we should ensure proper handling of the PDF content format.
Let's check how the PDF content is handled across the codebase:
✅ Verification successful
Let me gather more specific information about how the PDF content is handled in this context.
Let me check one more aspect to see how the PDF is being processed in the service layer.
PDF content handling is properly implemented
The implementation shows that the PDF content is handled appropriately:
- The service layer maps the response from
ojoiApplicationService.getPdf()to thepdffield usingdata.content - The PDF handling is part of a protected GraphQL endpoint with proper user authentication and scope checks
- The implementation follows the standard pattern used across the codebase for handling document content
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for PDF-related content handling
rg -l "pdf.*base64" || rg -l "application/pdf"
Length of output: 1313
Script:
#!/bin/bash
# Search for references to the GetPdfResponse or related PDF handling in the official-journal application
rg -A 5 "GetPdfResponse|getPdf" libs/api/domains/official-journal-of-iceland-application/
# Check the implementation details around this PDF field
ast-grep --pattern 'interface GetPdfResponse {
$$$
}'
Length of output: 6587
Script:
#!/bin/bash
# Look for the implementation of the getPdf method in the service
rg -A 10 "async getPdf" libs/api/domains/official-journal-of-iceland-application/
# Check for any PDF-related type definitions or utilities
rg -A 3 "pdf.*string" libs/api/domains/official-journal-of-iceland-application/
Length of output: 2823
libs/application/templates/official-journal-of-iceland/src/hooks/usePdf.ts (3)
1-3: LGTM! Clean and focused imports.
The imports are well-structured and follow good tree-shaking practices by importing specific entities.
1-28: LGTM! Meets libs directory guidelines.
The implementation successfully meets all requirements for libs directory:
- ✅ Reusable hook that can be used across different NextJS apps
- ✅ Proper TypeScript usage for all definitions
- ✅ Effective tree-shaking with specific imports
10-28: 🛠️ Refactor suggestion
Consider enhancing error handling and performance.
While the hook implementation is functional, there are several improvements we could make:
- Add error type definition and enhance error handling:
+type PdfError = {
+ message: string
+ code?: string
+}
+
export const usePdf = ({ applicationId, onComplete }: Props) => {
const [fetchPdf, { data, loading, error }] = useLazyQuery<{
OJOIAGetPdf: OjoiaGetPdfResponse
- }>(GET_PDF_QUERY, {
+ }, {
+ message: PdfError
+ }>(GET_PDF_QUERY, {
variables: {
input: {
id: applicationId,
},
},
onCompleted: onComplete,
+ onError: (error) => {
+ console.error('PDF fetch failed:', error.message)
+ }
})
+ const formattedError = React.useMemo(() => {
+ if (!error) return null
+ return {
+ message: error.message,
+ code: error.graphQLErrors[0]?.extensions?.code
+ }
+ }, [error])
+ const handleFetchPdf = React.useCallback(() => {
+ if (!applicationId) {
+ console.error('Application ID is required')
+ return
+ }
+ fetchPdf()
+ }, [applicationId, fetchPdf])
return {
- fetchPdf,
+ fetchPdf: handleFetchPdf,
pdf: data?.OJOIAGetPdf?.pdf,
loading,
- error,
+ error: formattedError,
}
}These changes will:
- Add proper error typing
- Memoize error formatting
- Add input validation
- Memoize the fetch function
- Improve error handling with logging
Let's verify the GraphQL error handling in other similar hooks:
libs/application/templates/official-journal-of-iceland/src/lib/messages/preview.ts (1)
33-42: LGTM! Well-structured error messages.
The new error messages follow the established pattern and provide clear feedback for PDF-related errors, with both a concise notification and a more detailed message including a retry suggestion.
libs/api/domains/official-journal-of-iceland-application/src/lib/ojoiApplication.resolver.ts (3)
30-30: LGTM! Import follows best practices.
The import statement correctly uses TypeScript types and follows tree-shaking practices by importing only the required type.
75-80: LGTM! Implementation follows resolver patterns.
The query method is well-structured with proper TypeScript types, authentication, and authorization.
75-80: Verify error handling in the service layer.
Since the resolver delegates to ojoiApplicationService.getPdf(), ensure proper error handling for scenarios like:
- PDF generation failures
- Invalid input IDs
- Authorization errors
libs/application/templates/official-journal-of-iceland/src/fields/Preview.tsx (2)
16-16: LGTM: Clean import organization and proper hook usage.
The new imports are well-organized and follow React best practices for custom hooks and utilities.
Also applies to: 30-30
109-119: LGTM: Well-implemented download button.
The button implementation properly handles loading states and follows the island-ui design system guidelines.
libs/api/domains/official-journal-of-iceland-application/src/lib/ojoiApplication.service.ts (1)
27-28: LGTM! Clean type imports.
The new type imports follow TypeScript best practices and maintain consistency with the existing codebase.
libs/clients/official-journal-of-iceland/application/src/clientConfig.json (3)
476-480: LGTM: Well-documented typeName field addition
The new typeName field is properly documented with example and description, and correctly added to the required fields list.
Also applies to: 514-514
1092-1120: LGTM: Well-structured CaseStatus schema
The new CaseStatus schema is well-defined with:
- Clear property definitions
- Comprehensive enum values for status titles
- Required field specifications
1201-1204: LGTM: Improved type safety for ApplicationCase status
Good refactoring to use the CaseStatus schema reference instead of an inline object type, improving type safety and reusability.
libs/application/templates/official-journal-of-iceland/src/hooks/usePdf.ts
Outdated
Show resolved
Hide resolved
libs/application/templates/official-journal-of-iceland/src/lib/messages/preview.ts
Show resolved
Hide resolved
libs/clients/official-journal-of-iceland/application/src/lib/ojoiApplicationClient.service.ts
Show resolved
Hide resolved
libs/application/templates/official-journal-of-iceland/src/fields/Preview.tsx
Show resolved
Hide resolved
libs/application/templates/official-journal-of-iceland/src/fields/Preview.tsx
Show resolved
Hide resolved
libs/application/templates/official-journal-of-iceland/src/fields/Preview.tsx
Outdated
Show resolved
Hide resolved
libs/api/domains/official-journal-of-iceland-application/src/lib/ojoiApplication.service.ts
Outdated
Show resolved
Hide resolved
libs/application/templates/official-journal-of-iceland/src/lib/utils.ts
Outdated
Show resolved
Hide resolved
libs/clients/official-journal-of-iceland/application/src/clientConfig.json
Show resolved
Hide resolved
Datadog ReportAll test runs ✅ 66 Total Test Services: 0 Failed, 63 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (3) |
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Outside diff range and nitpick comments (2)
libs/application/templates/official-journal-of-iceland/src/lib/messages/preview.ts (1)
33-52: Consider grouping PDF-related messages for better maintainability.The error messages are well-structured and provide good user feedback. However, as we add more PDF-related functionality, consider grouping these messages in a nested structure.
Here's a suggested restructuring:
export const preview = { errors: defineMessages({ noContent: { // ... existing messages }, pdf: { error: { id: 'ojoi.application:preview.errors.pdf.error', defaultMessage: 'Villa kom upp við að sækja skjal', description: 'Error message when pdf download fails', }, errorMessage: { id: 'ojoi.application:preview.errors.pdf.errorMessage', defaultMessage: 'Ekki tókst að sækja skjal, reyndu aftur', description: 'Error message when pdf download fails', }, invalid: { id: 'ojoi.application:preview.errors.pdf.invalid', defaultMessage: 'Ógilt skjal', description: 'Error message when pdf is invalid', }, invalidMessage: { id: 'ojoi.application:preview.errors.pdf.invalidMessage', defaultMessage: 'Skjalið er ógilt eða á vitlausu formi, reyndu aftur', description: 'Error message when pdf is invalid', }, }, }), }libs/application/templates/official-journal-of-iceland/src/lib/utils.ts (1)
346-353: Consider adding JSDoc documentation for better reusability.Since this utility is in the
libsdirectory and meant to be reusable, adding proper documentation would improve its usability across different parts of the application.Add JSDoc documentation:
+/** + * Converts a base64 string to a Blob object. + * @param base64 - The base64 encoded string to convert + * @param mimeType - The MIME type of the resulting Blob (default: 'application/pdf') + * @throws {Error} When the input string is empty or invalid + * @returns A Blob object containing the decoded data + */ export const base64ToBlob = (base64: string, mimeType = 'application/pdf'): Blob => {
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (5)
libs/api/domains/official-journal-of-iceland-application/src/lib/ojoiApplication.service.ts(2 hunks)libs/application/templates/official-journal-of-iceland/src/fields/Preview.tsx(5 hunks)libs/application/templates/official-journal-of-iceland/src/hooks/usePdf.ts(1 hunks)libs/application/templates/official-journal-of-iceland/src/lib/messages/preview.ts(1 hunks)libs/application/templates/official-journal-of-iceland/src/lib/utils.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- libs/application/templates/official-journal-of-iceland/src/hooks/usePdf.ts
🧰 Additional context used
📓 Path-based instructions (4)
libs/api/domains/official-journal-of-iceland-application/src/lib/ojoiApplication.service.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/official-journal-of-iceland/src/fields/Preview.tsx (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/official-journal-of-iceland/src/lib/messages/preview.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/official-journal-of-iceland/src/lib/utils.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
🔇 Additional comments (4)
libs/api/domains/official-journal-of-iceland-application/src/lib/ojoiApplication.service.ts (1)
27-28: LGTM: Imports follow TypeScript best practices.
The new imports maintain consistency with the existing import patterns and ensure proper type safety.
libs/application/templates/official-journal-of-iceland/src/fields/Preview.tsx (3)
16-16: Well-structured imports following best practices!
The modular approach with separate utilities and hooks promotes reusability across different NextJS apps and enables effective tree-shaking.
Also applies to: 30-31
120-155: Well-structured error handling implementation!
The error handling is comprehensive with:
- Clear separation of different error states (PDF error vs invalid PDF)
- User-friendly error messages
- Proper TypeScript usage for conditional rendering
33-89: Excellent TypeScript implementation!
The component demonstrates strong TypeScript practices:
- Proper typing of props and hooks
- Type-safe error handling
- Well-defined interfaces for external data
libs/api/domains/official-journal-of-iceland-application/src/lib/ojoiApplication.service.ts
Show resolved
Hide resolved
libs/application/templates/official-journal-of-iceland/src/fields/Preview.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (2)
libs/application/templates/official-journal-of-iceland/src/lib/messages/error.ts (2)
215-219: LGTM with minor suggestions for improvement.The new error message follows the established pattern and integrates well with existing messages. Consider making the message more specific about email requirements.
invalidChannel: { id: 'ojoi.application:error.invalidChannel', - defaultMessage: 'Samskiptaleið þarf að vera með gilt netfang', + defaultMessage: 'Samskiptaleið þarf að vera með gilt netfang (t.d. nafn@fyrirtaeki.is)', description: 'Error message when channel is invalid', },
Line range hint
1-219: Consider reorganizing email-related messages for better maintainability.Currently, there are multiple email-related error messages scattered throughout the file (
invalidChannel). Consider grouping them together for better maintainability.email: { id: 'ojoi.application:error.email', defaultMessage: 'Athugaðu hvort netfang sé rétt slegið inn', description: 'Error message when email is invalid or not present', }, + invalidChannel: { + id: 'ojoi.application:error.invalidChannel', + defaultMessage: 'Samskiptaleið þarf að vera með gilt netfang', + description: 'Error message when channel is invalid', + }, phone: { id: 'ojoi.application:error.phone', defaultMessage: 'Athugaðu hvort símanúmer sé rétt slegið inn', description: 'Error message when phone is invalid or not present', }, - invalidChannel: { - id: 'ojoi.application:error.invalidChannel', - defaultMessage: 'Samskiptaleið þarf að vera með gilt netfang', - description: 'Error message when channel is invalid', - },
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (2)
libs/application/templates/official-journal-of-iceland/src/lib/dataSchema.ts(3 hunks)libs/application/templates/official-journal-of-iceland/src/lib/messages/error.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
libs/application/templates/official-journal-of-iceland/src/lib/dataSchema.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/official-journal-of-iceland/src/lib/messages/error.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
🔇 Additional comments (2)
libs/application/templates/official-journal-of-iceland/src/lib/dataSchema.ts (2)
123-134: LGTM! Robust channel validation implementation.
The validation logic for channels is well-implemented:
- Makes the field optional but ensures at least one valid channel when present
- Uses the validateChannel function for individual channel validation
- Provides appropriate error feedback
Line range hint 6-361: Verify the impact of new validation rules.
Let's verify the usage of these new validation rules across the codebase to ensure compatibility.
✅ Verification successful
Let me analyze the results and generate a final response since we have comprehensive information about email validation patterns and channel schema usage across the codebase.
Email validation and channel schema changes are safe to proceed.
- The new email validation regex in the official journal template matches the pattern used consistently across other templates in the codebase
- The channel schema and validation is only used within the official journal template (
libs/application/templates/official-journal-of-iceland/src/lib/dataSchema.ts) and doesn't affect other parts of the codebase - The email validation function follows the same pattern (optional check with regex test) as used in other templates
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for potential impacts of the new validation rules
# Test 1: Find all files that might be affected by the new email validation
echo "Files potentially affected by email validation:"
rg -l "email.*validation|validateEmail|isValidEmail"
# Test 2: Find all usages of the channel schema
echo "\nFiles using channel schema or validation:"
rg -l "channelSchema|validateChannel"
# Test 3: Check for any existing email regex patterns that might conflict
echo "\nExisting email validation patterns:"
rg -B 2 -A 2 'email.*regex|emailRegex'
Length of output: 17091
libs/application/templates/official-journal-of-iceland/src/lib/dataSchema.ts
Show resolved
Hide resolved
libs/application/templates/official-journal-of-iceland/src/lib/dataSchema.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
libs/application/templates/official-journal-of-iceland/src/lib/dataSchema.ts (1)
6-9: Specify explicit return types for functionsIt's good practice in TypeScript to explicitly specify the return type of functions to enhance type safety and code readability. Consider adding an explicit return type to the
isValidEmailfunction.-const isValidEmail = (value?: string) => +const isValidEmail = (value?: string): boolean =>
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (2)
libs/application/templates/official-journal-of-iceland/src/lib/dataSchema.ts(3 hunks)libs/application/templates/official-journal-of-iceland/src/lib/messages/error.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- libs/application/templates/official-journal-of-iceland/src/lib/messages/error.ts
🧰 Additional context used
📓 Path-based instructions (1)
libs/application/templates/official-journal-of-iceland/src/lib/dataSchema.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
🔇 Additional comments (1)
libs/application/templates/official-journal-of-iceland/src/lib/dataSchema.ts (1)
376-380: LGTM!
The validateChannel function correctly validates the channel's email field using the isValidEmail function.
libs/application/templates/official-journal-of-iceland/src/lib/dataSchema.ts
Show resolved
Hide resolved
What
Downloading pdf received from external api
Why
So users can download a pdf of their advert.
Checklist:
Summary by CodeRabbit
New Features
GET_PDF_QUERYto fetch PDF documents.getPdfmethod for retrieving PDFs based on input IDs.usePdffor managing PDF fetching.Enhancements
Previewcomponent.API Changes
ApplicationAdvertschema with additional properties.