fix(j-s): Display verdict view date for defenders

[oddsson]

Display verdict view date for defenders

Asana

What

This PR addresses issues from #16709.

1. Fixes typo -- Birting skal dómfellda dóminn ➡️ Birta skal dómfellda dóminn
2. Display verdict view date for defenders in their info cards.

Why

These are bugs

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• Updates
  • Updated the message ID and default text for the service requirement in the Defendant Info section.
  • Adjusted the rendering logic for the Indictment Overview, ensuring consistent display of verdict dates for closed and active indictments.

[coderabbitai]

Warning

Rate limit exceeded

@oddsson has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 10 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 129bd5f and 52e8a5a.

Walkthrough

The pull request introduces changes to the DefendantInfo.strings.ts file by updating the serviceRequired message's identifier and default message. In the IndictmentOverview.tsx file, modifications are made to the rendering logic of the InfoCardClosedIndictment and InfoCardActiveIndictment components, specifically regarding the displayVerdictViewDate prop. The overall structure and functionality of the components remain unchanged.

Changes

File Path	Change Summary
apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.strings.ts	Updated serviceRequired message ID and default message.
apps/judicial-system/web/src/routes/Shared/IndictmentOverview/IndictmentOverview.tsx	Modified rendering logic for InfoCardClosedIndictment and InfoCardActiveIndictment components regarding displayVerdictViewDate prop.

Possibly related PRs

• feat(j-s): Indictment View Tag #14922: This PR modifies the DefendantInfo.tsx file, which is directly related to the changes made in DefendantInfo.strings.ts in the main PR, as both involve updates to the defendant information display.
• fix(j-s): Handle no defender assigned in indictment case InfoCard #15414: This PR adds a new message to DefendantInfo.strings.ts, which is relevant to the changes in the main PR that also involve modifications to the strings related to defendant information.
• fix(j-s): Display correct verdict appeal info for defenders  #16533: This PR addresses the display of verdict appeal information for defenders, which is closely related to the changes made in the main PR regarding the serviceRequired message in DefendantInfo.strings.ts.
• chore(j-s): Display service status on info card for prosecutors #16709: This PR enhances the service status display on info cards for prosecutors, which connects to the changes in the main PR that involve updates to the DefendantInfo.strings.ts file, as both are concerned with the information displayed in the context of defendants.

Suggested labels

high priority

Suggested reviewers

• unakb

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.53%. Comparing base (129bd5f) to head (52e8a5a).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...s/Shared/IndictmentOverview/IndictmentOverview.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #16789   +/-   ##
=======================================
  Coverage   36.53%   36.53%           
=======================================
  Files        6892     6892           
  Lines      143894   143894           
  Branches    41016    41016           
=======================================
  Hits        52578    52578           
  Misses      91316    91316           

Flag	Coverage Δ
judicial-system-web	27.54% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ts/InfoCard/DefendantInfo/DefendantInfo.strings.ts	100.00% <ø> (ø)
...s/Shared/IndictmentOverview/IndictmentOverview.tsx	0.00% <0.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 129bd5f...52e8a5a. Read the comment docs.

[datadog-island-is]

Datadog Report

Branch report: j-s/infocard-redesign-2
Commit report: 55298e1
Test service: judicial-system-web

✅ 0 Failed, 333 Passed, 0 Skipped, 57.41s Total Time
➡️ Test Sessions change in coverage: 1 no change

[unakb]

Nice :)!