Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codeowners): modify ownership of health directorate clients #16904

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

jonarnarbriem
Copy link
Member

@jonarnarbriem jonarnarbriem commented Nov 15, 2024

...

Attach a link to issue if relevant

What

Narrowed Hugsmiðjan-Origo shared ownership of health directorate clients to only occupational-licenses. Left Hugmsiðjan as sole owner of other health-directorate clients.

Why

To clarify ownership

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • Chores
    • Updated ownership structure for project directories, reallocating responsibilities for better management.

@jonarnarbriem jonarnarbriem requested a review from a team as a code owner November 15, 2024 14:44
Copy link
Contributor

coderabbitai bot commented Nov 15, 2024

Walkthrough

The changes in this pull request involve modifications to the .github/CODEOWNERS file, specifically reallocating ownership for certain project directories. The ownership of the /libs/clients/health-directorate path has been removed from the @island-is/origo team and assigned to @island-is/hugsmidjan, while ownership for the new path /libs/clients/health-directorate/src/lib/clients/occupational-license has been granted to both @island-is/hugsmidjan and @island-is/origo. This reflects a restructuring of responsibilities without altering the overall hierarchy of the CODEOWNERS file.

Changes

File Path Change Summary
.github/CODEOWNERS Removed ownership for /libs/clients/health-directorate from @island-is/origo; added ownership for /libs/clients/health-directorate/src/lib/clients/occupational-license to @island-is/hugsmidjan and @island-is/origo.

Possibly related PRs

Suggested labels

automerge

Suggested reviewers

  • robertaandersen
  • thordurhhh

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jonarnarbriem jonarnarbriem added the automerge Merge this PR as soon as all checks pass label Nov 15, 2024
Copy link
Member

@robertaandersen robertaandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.52%. Comparing base (e6dbd6d) to head (6390c7d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16904      +/-   ##
==========================================
+ Coverage   36.42%   36.52%   +0.09%     
==========================================
  Files        6855     6858       +3     
  Lines      143645   143697      +52     
  Branches    40996    41003       +7     
==========================================
+ Hits        52327    52483     +156     
+ Misses      91318    91214     -104     
Flag Coverage Δ
judicial-system-api 19.86% <ø> (ø)
judicial-system-backend 55.73% <ø> (+0.53%) ⬆️
judicial-system-formatters 79.35% <ø> (ø)
judicial-system-message 67.05% <ø> (ø)
judicial-system-message-handler 48.08% <ø> (ø)
judicial-system-scheduler 70.79% <ø> (ø)
judicial-system-types 43.31% <ø> (ø)
judicial-system-web 27.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 22 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6dbd6d...6390c7d. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

All test runs 59cbc81 🔗

9 Total Test Services: 0 Failed, 9 Passed
➡️ Test Sessions change in coverage: 12 no change

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
judicial-system-api 0 0 0 59 0 6.91s 1 no change Link
judicial-system-backend 0 0 0 21020 0 22m 2.51s 1 no change Link
judicial-system-formatters 0 0 0 38 0 5.8s 1 no change Link
judicial-system-message 0 0 0 35 0 12.15s 1 no change Link
judicial-system-message-handler 0 0 0 4 0 3.92s 1 no change Link
judicial-system-scheduler 0 0 0 4 0 4.73s 1 no change Link
judicial-system-types 0 0 0 23 0 8.39s 1 no change Link
judicial-system-web 0 0 0 333 0 1m 18s 1 no change Link
judicial-system-xrd-api 0 0 0 6 0 5.92s 1 no change Link

@kodiakhq kodiakhq bot merged commit 4f47813 into main Nov 15, 2024
36 checks passed
@kodiakhq kodiakhq bot deleted the fix/update-health-directorate-codeowners branch November 15, 2024 16:52
jonnigs pushed a commit that referenced this pull request Nov 26, 2024
…6904)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@coderabbitai coderabbitai bot mentioned this pull request Jan 7, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants