Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(j-s): String Length Validation #16924

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix(j-s): String Length Validation #16924

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84d5826
Validates varchar 255 fields
gudjong Nov 18, 2024
1562e0c
Merge branch 'main' into j-s/max-length-validation
kodiakhq[bot] Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions apps/judicial-system/backend/src/app/modules/case/dto/createCase.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
IsObject,
IsOptional,
IsString,
MaxLength,
} from 'class-validator'

import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger'
Expand All @@ -31,33 +32,39 @@ export class CreateCaseDto {
readonly indictmentSubtypes?: IndictmentSubtypeMap

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly description?: string

@IsNotEmpty()
@IsArray()
@ArrayMinSize(1)
@MaxLength(255)
@IsString({ each: true })
@ApiProperty({ type: String, isArray: true })
readonly policeCaseNumbers!: string[]

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly defenderName?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly defenderNationalId?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly defenderEmail?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
gudjong marked this conversation as resolved.
Show resolved Hide resolved
readonly defenderPhoneNumber?: string
Expand All @@ -68,6 +75,7 @@ export class CreateCaseDto {
readonly requestSharedWithDefender?: RequestSharedWithDefender

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly leadInvestigator?: string
Expand Down
13 changes: 13 additions & 0 deletions apps/judicial-system/backend/src/app/modules/case/dto/updateCase.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
IsOptional,
IsString,
IsUUID,
MaxLength,
ValidateNested,
} from 'class-validator'

Expand Down Expand Up @@ -43,6 +44,7 @@ class UpdateDateLog {
readonly date?: Date

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly location?: string
Expand All @@ -60,33 +62,39 @@ export class UpdateCaseDto {
readonly indictmentSubtypes?: IndictmentSubtypeMap

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly description?: string

@IsOptional()
@IsArray()
@ArrayMinSize(1)
@MaxLength(255)
@IsString({ each: true })
gudjong marked this conversation as resolved.
Show resolved Hide resolved
@ApiPropertyOptional({ type: String, isArray: true })
readonly policeCaseNumbers?: string[]

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly defenderName?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly defenderNationalId?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly defenderEmail?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly defenderPhoneNumber?: string
Expand All @@ -107,6 +115,7 @@ export class UpdateCaseDto {
readonly courtId?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly leadInvestigator?: string
Expand All @@ -124,6 +133,7 @@ export class UpdateCaseDto {
readonly requestedCourtDate?: Date

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly translator?: string
Expand Down Expand Up @@ -207,6 +217,7 @@ export class UpdateCaseDto {
readonly sharedWithProsecutorsOfficeId?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly courtCaseNumber?: string
Expand All @@ -229,6 +240,7 @@ export class UpdateCaseDto {
readonly courtDate?: UpdateDateLog

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly courtLocation?: string
Expand Down Expand Up @@ -407,6 +419,7 @@ export class UpdateCaseDto {
readonly defendantStatementDate?: Date

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly appealCaseNumber?: string
Expand Down
16 changes: 15 additions & 1 deletion apps/judicial-system/backend/src/app/modules/defendant/dto/createDefendant.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
import { IsBoolean, IsEnum, IsOptional, IsString } from 'class-validator'
import {
IsBoolean,
IsEnum,
IsOptional,
IsString,
MaxLength,
} from 'class-validator'

import { ApiPropertyOptional } from '@nestjs/swagger'

Expand All @@ -11,11 +17,13 @@ export class CreateDefendantDto {
readonly noNationalId?: boolean

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly nationalId?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly name?: string
Expand All @@ -26,31 +34,37 @@ export class CreateDefendantDto {
readonly gender?: Gender

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly address?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly citizenship?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly defenderName?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly defenderNationalId?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly defenderEmail?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly defenderPhoneNumber?: string
Expand Down
8 changes: 7 additions & 1 deletion apps/judicial-system/backend/src/app/modules/defendant/dto/updateCivilClaimant.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { IsBoolean, IsOptional, IsString } from 'class-validator'
import { IsBoolean, IsOptional, IsString, MaxLength } from 'class-validator'

import { ApiPropertyOptional } from '@nestjs/swagger'

Expand All @@ -9,11 +9,13 @@ export class UpdateCivilClaimantDto {
readonly noNationalId?: boolean

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly name?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly nationalId?: string
Expand All @@ -29,21 +31,25 @@ export class UpdateCivilClaimantDto {
readonly spokespersonIsLawyer?: boolean

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly spokespersonNationalId?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly spokespersonName?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly spokespersonEmail?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly spokespersonPhoneNumber?: string
Expand Down
11 changes: 11 additions & 0 deletions apps/judicial-system/backend/src/app/modules/defendant/dto/updateDefendant.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
IsEnum,
IsOptional,
IsString,
MaxLength,
} from 'class-validator'

import { ApiPropertyOptional } from '@nestjs/swagger'
Expand All @@ -24,11 +25,13 @@ export class UpdateDefendantDto {
readonly noNationalId?: boolean

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly nationalId?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly name?: string
Expand All @@ -39,31 +42,37 @@ export class UpdateDefendantDto {
readonly gender?: Gender

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly address?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly citizenship?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly defenderName?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly defenderNationalId?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly defenderEmail?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly defenderPhoneNumber?: string
gudjong marked this conversation as resolved.
Show resolved Hide resolved
Expand Down Expand Up @@ -106,11 +115,13 @@ export class UpdateDefendantDto {
readonly requestedDefenderChoice?: DefenderChoice

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly requestedDefenderNationalId?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly requestedDefenderName?: string
Expand Down
6 changes: 6 additions & 0 deletions apps/judicial-system/backend/src/app/modules/file/dto/createFile.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
IsNumber,
IsOptional,
IsString,
MaxLength,
} from 'class-validator'

import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger'
Expand All @@ -14,6 +15,7 @@ import { CaseFileCategory } from '@island.is/judicial-system/types'

export class CreateFileDto {
@IsNotEmpty()
@MaxLength(255)
@IsString()
@ApiProperty({ type: String })
readonly type!: string
Expand All @@ -24,6 +26,7 @@ export class CreateFileDto {
readonly category?: CaseFileCategory

@IsNotEmpty()
@MaxLength(255)
@IsString()
@ApiProperty({ type: String })
readonly key!: string
Expand All @@ -34,6 +37,7 @@ export class CreateFileDto {
readonly size!: number

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly policeCaseNumber?: string
Expand All @@ -55,11 +59,13 @@ export class CreateFileDto {
readonly displayDate?: Date

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly policeFileId?: string

@IsOptional()
@MaxLength(255)
@IsString()
@ApiPropertyOptional({ type: String })
readonly userGeneratedFilename?: string
Expand Down
4 changes: 3 additions & 1 deletion apps/judicial-system/backend/src/app/modules/file/dto/createPresignedPost.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
import { IsNotEmpty, IsString } from 'class-validator'
import { IsNotEmpty, IsString, MaxLength } from 'class-validator'

import { ApiProperty } from '@nestjs/swagger'

export class CreatePresignedPostDto {
@IsNotEmpty()
@MaxLength(255)
@IsString()
@ApiProperty({ type: String })
readonly fileName!: string

@IsNotEmpty()
@MaxLength(255)
@IsString()
@ApiProperty({ type: String })
readonly type!: string
Expand Down
Loading
Loading