fix(application-system): Add application-system grant to user-notification

[norda-gunni]

...

Attach a link to issue if relevant

What

Add application-system grant to user-notification

Why

So application-system users can get their notifications

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features

  • Expanded permissions for the user notification services by adding the application-system namespace.
  • Updated health check readiness path for user notification services from /liveness to /health/check.

• Bug Fixes

  • No significant bug fixes were included in this release.

• Documentation

  • Updated configuration files to reflect the new namespace permissions and health check paths.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve modifications to several configuration files related to the user notification services. The primary update is the addition of the string 'application-system' to the grantNamespaces lists across various services, which expands their access permissions. Additionally, health check paths for the user-notification service are updated from /liveness to /health/check. These changes apply to multiple environments including development, production, and staging.

Changes

File Path	Change Summary
apps/services/user-notification/infra/user-notification.ts	Updated grantNamespaces in userNotificationServiceSetup to include 'application-system'.
charts/islandis/values.dev.yaml	Added 'application-system' to grantNamespaces for user-notification, user-notification-cleanup-worker, and user-notification-worker. Changed health check path from /liveness to /health/check.
charts/islandis/values.prod.yaml	Added 'application-system' to grantNamespaces for user-notification, user-notification-cleanup-worker, and user-notification-worker. Changed health check path from /liveness to /health/check.
charts/islandis/values.staging.yaml	Added 'application-system' to grantNamespaces for user-notification, user-notification-cleanup-worker, and user-notification-worker. Changed health check path for user-notification to /health/check.
charts/services/user-notification-cleanup-worker/values.dev.yaml	Added 'application-system' to grantNamespaces.
charts/services/user-notification-cleanup-worker/values.prod.yaml	Added 'application-system' to grantNamespaces.
charts/services/user-notification-cleanup-worker/values.staging.yaml	Added 'application-system' to grantNamespaces.
charts/services/user-notification-worker/values.dev.yaml	Added 'application-system' to grantNamespaces.
charts/services/user-notification-worker/values.prod.yaml	Added 'application-system' to grantNamespaces.
charts/services/user-notification-worker/values.staging.yaml	Added 'application-system' to grantNamespaces.
charts/services/user-notification/values.dev.yaml	Added 'application-system' to grantNamespaces.
charts/services/user-notification/values.prod.yaml	Added 'application-system' to grantNamespaces.
charts/services/user-notification/values.staging.yaml	Added 'application-system' to grantNamespaces.

Possibly related PRs

• infra(services-auth-delegation-api): Grant user-notification-worker access to delegation-api #15912: This PR expands the list of namespaces granted to the user-notification-worker, which is directly related to the changes made in the main PR that also involve granting access to the application-system namespace.
• fix: added missing grant to auth ids api for user notification #16680: This PR adds a missing grant for the user-notification namespace in the auth ids api, which aligns with the main PR's focus on enhancing permissions for the user-notification service.
• fix: Add namespace grants for services that need it, but don't have it #16697: This PR adds namespace grants for services that need it, specifically including user-notification, which is relevant to the changes in the main PR that also involve granting access to this namespace.
• fix(download-service): Grant namespace to bff admin portal #16728: This PR grants the services-bff-portals-admin namespace to the download-service, which is related to the overall theme of enhancing namespace permissions seen in the main PR.
• fix(application-system-api): add secret from aws parameter store for national registry client v3 #16782: This PR adds a secret for the national registry client v3, which is relevant as it pertains to the configuration of the user-notification service, enhancing its integration capabilities.
• chore(application-system): Increase cpu and mem limit and request to avoid crashloops #16792: This PR increases CPU and memory limits for the application-system-api, which is relevant as it relates to the overall resource management and performance improvements that may impact the user-notification service.
• chore(application-system): Set initialDelay to 20 seconds #16893: This PR sets the initial delay for health checks, which is relevant to the stability and performance of the user-notification service during startup, aligning with the changes in the main PR.

Suggested labels

high priority

Suggested reviewers

• thorkellmani
• svanaeinars
• albinagu

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[brynjarorng]

LGTM