feat(tests): move e2e tests for consultation-portal to their app #17008
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,7 @@ | |
| **/*.log | ||
| **/tmp/ | ||
| **/temp/ | ||
| **/.next/ | ||
|
|
||
| # Outputs | ||
| **/dist/ | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| ARG NODE_IMAGE_TAG=20.15.0-alpine3.20 | ||
|
|
||
| # Stage 1: Install dependencies | ||
| FROM node:${NODE_IMAGE_TAG} AS dependencies | ||
|
|
||
| # Set working directory | ||
| WORKDIR /app | ||
|
|
||
| # Install Python3 and build tools | ||
| RUN apk add --no-cache python3 py3-pip make g++ && ln -sf /usr/bin/python3 /usr/bin/python | ||
|
|
||
| # Copy only package management files | ||
| COPY package.json yarn.lock ./ | ||
| COPY .yarn/ .yarn | ||
| COPY .yarnrc.yml .yarnrc.yml | ||
| COPY ./apps/native/app/package.json ./apps/native/app/package.json | ||
|
|
||
| # Install dependencies | ||
| RUN --mount=type=cache,target=/app/.yarn/cache \ | ||
| yarn install --immutable && yarn cache clean | ||
|
|
||
| # Stage 2: Final runtime image | ||
| FROM node:${NODE_IMAGE_TAG} | ||
|
|
||
| # Install Python (runtime requirement if needed) | ||
| RUN apk add --no-cache python3 py3-pip && ln -sf /usr/bin/python3 /usr/bin/python | ||
|
|
||
| # Enable Corepack and Yarn 3.2.3 | ||
| RUN corepack enable && corepack prepare yarn@3.2.3 --activate | ||
|
|
||
| # Set working directory | ||
| WORKDIR /app | ||
|
|
||
| # Copy from dependencies stage | ||
| COPY --from=dependencies /app/node_modules ./node_modules | ||
| COPY --from=dependencies /app/yarn.lock ./yarn.lock | ||
| COPY --from=dependencies /app/.yarn/ ./.yarn | ||
| COPY --from=dependencies /app/.yarnrc.yml ./.yarnrc.yml | ||
|
|
||
| # Copy source code and necessary configuration files | ||
| COPY ./apps ./apps | ||
| COPY ./libs ./libs | ||
| COPY ./infra ./infra | ||
| COPY ./tools ./tools | ||
| COPY ./tsconfig.base.json ./ | ||
| COPY ./tsconfig.shared.json ./ | ||
| COPY ./package.json ./ | ||
|
|
||
| # Verify Yarn version in runtime container | ||
| RUN yarn --version | ||
|
|
||
| # Default command to run the app | ||
| CMD ["yarn", "nx", "serve"] | ||
|
|
||
| # ARG NODE_IMAGE_TAG=20.15.0-alpine3.20 | ||
| # FROM node:${NODE_IMAGE_TAG} AS build | ||
|
|
||
| # WORKDIR /app | ||
|
|
||
| # # Install build dependencies | ||
| # RUN apk add --no-cache \ | ||
| # python3 \ | ||
| # py3-pip \ | ||
| # make \ | ||
| # g++ | ||
|
|
||
| # # Set Python symlink | ||
| # RUN ln -sf /usr/bin/python3 /usr/bin/python | ||
|
|
||
| # # Install dependencies | ||
| # COPY package.json yarn.lock ./ | ||
| # COPY .yarn/ .yarn | ||
| # COPY .yarnrc.yml .yarnrc.yml | ||
| # COPY ./apps/native/app/package.json ./apps/native/app/package.json | ||
|
|
||
| # # Run yarn install | ||
| # RUN --mount=type=cache,target=/app/.yarn/cache \ | ||
| # yarn install --immutable | ||
|
|
||
| # # Copy source code | ||
| # COPY . . | ||
|
|
||
| # # Verify installation | ||
| # RUN yarn nx --version | ||
|
|
||
| # # Set default entrypoint | ||
| # CMD ["yarn", "nx"] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| import { | ||
| BrowserContext, | ||
| expect, | ||
| test, | ||
| icelandicAndNoPopupUrl, | ||
| urls, | ||
| session, | ||
| } from '@island.is/testing/e2e' | ||
|
|
||
| test.describe('Consultation portal authenticated', { tag: '@fast' }, () => { | ||
| let context: BrowserContext | ||
| test.use({ baseURL: urls.islandisBaseUrl }) | ||
|
|
||
| test.beforeAll(async ({ browser }) => { | ||
| context = await session({ | ||
| browser: browser, | ||
| storageState: 'consultation-auth.json', | ||
| idsLoginOn: { | ||
| nextAuth: { nextAuthRoot: `${urls.islandisBaseUrl}/samradsgatt` }, | ||
| }, | ||
| phoneNumber: '0102989', | ||
| homeUrl: `${urls.islandisBaseUrl}/samradsgatt`, | ||
| authTrigger: async (page) => { | ||
| await page.goto('/samradsgatt') | ||
| await page.getByTestId('menu-login-btn').click() | ||
| return `${urls.islandisBaseUrl}/samradsgatt` | ||
| }, | ||
| }) | ||
| }) | ||
|
|
||
| test.afterAll(async () => { | ||
| if (context) { | ||
| await context.close() | ||
| } | ||
| }) | ||
|
Comment on lines
+14
to
+35
There was a problem hiding this comment. 🛠️ Refactor suggestion Add error handling and avoid hard-coded test data The setup hooks are functional but could be improved in several areas:
authTrigger: async (page) => {
try {
await page.goto('/samradsgatt')
await page.getByTestId('menu-login-btn').click()
return `${urls.islandisBaseUrl}/samradsgatt`
} catch (error) {
console.error('Auth trigger failed:', error)
throw error
}
}
// test-config.ts
export const TEST_DATA = {
phoneNumber: '0102989',
storageState: 'consultation-auth.json',
// ... other test constants
}
|
||
|
|
||
| test('logged in user should be shown instead of login', async () => { | ||
| const page = await context.newPage() | ||
| await page.goto(icelandicAndNoPopupUrl('/samradsgatt')) | ||
|
|
||
| await expect( | ||
| page.getByRole('button', { name: 'Gervimaður Ameríku' }), | ||
| ).toBeVisible() | ||
| await expect(page.getByTestId('menu-login-btn')).not.toBeVisible() | ||
|
|
||
| await page.close() | ||
| }) | ||
|
|
||
| test('subscriptions page should show logged in state', async () => { | ||
| const page = await context.newPage() | ||
| await page.goto(icelandicAndNoPopupUrl('/samradsgatt')) | ||
|
|
||
| await page.getByTestId('subscriptions-btn').click() | ||
| await expect(page.getByTestId('subscriptions-title')).toBeVisible() | ||
| await expect(page.getByTestId('action-card')).toBeVisible() | ||
| await expect( | ||
| page.getByRole('button', { | ||
| name: 'Skrá mig inn', | ||
| }), | ||
| ).not.toBeVisible() | ||
|
|
||
| await page.close() | ||
| }) | ||
|
|
||
| test('my subscriptions page should show logged in state', async () => { | ||
| const page = await context.newPage() | ||
| await page.goto(icelandicAndNoPopupUrl('/samradsgatt/minaraskriftir')) | ||
| await expect(page.getByTestId('subscriptions-title')).toBeVisible() | ||
| await expect(page.getByTestId('action-card')).not.toBeVisible() | ||
|
|
||
| await page.close() | ||
| }) | ||
|
|
||
| test('advices page should show logged in state', async () => { | ||
| const page = await context.newPage() | ||
| await page.goto(icelandicAndNoPopupUrl('/samradsgatt')) | ||
|
|
||
| await page.goto('/umsagnir') | ||
| await expect(page.getByTestId('actionCard')).not.toBeVisible() | ||
|
|
||
| await page.close() | ||
| }) | ||
|
|
||
| test('logout button should be visible', async () => { | ||
| const page = await context.newPage() | ||
| await page.goto(icelandicAndNoPopupUrl('/samradsgatt')) | ||
|
|
||
| await page.getByRole('button', { name: 'Gervimaður Ameríku' }).click() | ||
| await expect(page.getByRole('button', { name: 'Útskrá' })).toBeVisible() | ||
|
|
||
| await page.close() | ||
| }) | ||
|
|
||
| // Additional tests | ||
| test('user should be able to navigate to profile page', async () => { | ||
| const page = await context.newPage() | ||
| await page.goto(icelandicAndNoPopupUrl('/samradsgatt')) | ||
|
|
||
| await page.getByRole('button', { name: 'Gervimaður Ameríku' }).click() | ||
| await page.getByRole('link', { name: 'Mínar síður' }).click() | ||
| await expect(page.getByTestId('profile-page')).toBeVisible() | ||
|
|
||
| await page.close() | ||
| }) | ||
|
|
||
| test('user should be able to update profile information', async () => { | ||
| const page = await context.newPage() | ||
| await page.goto(icelandicAndNoPopupUrl('/samradsgatt/minar-sidur')) | ||
|
|
||
| await page.getByTestId('edit-profile-btn').click() | ||
| await page.fill('input[name="name"]', 'Updated Name') | ||
| await page.getByTestId('save-profile-btn').click() | ||
| await expect(page.getByTestId('profile-name')).toHaveText('Updated Name') | ||
|
|
||
| await page.close() | ||
| }) | ||
|
|
||
| test('user should be able to view notifications', async () => { | ||
| const page = await context.newPage() | ||
| await page.goto(icelandicAndNoPopupUrl('/samradsgatt')) | ||
|
|
||
| await page.getByRole('button', { name: 'Gervimaður Ameríku' }).click() | ||
| await page.getByRole('link', { name: 'Tilkynningar' }).click() | ||
| await expect(page.getByTestId('notifications-page')).toBeVisible() | ||
|
|
||
| await page.close() | ||
| }) | ||
|
|
||
| test('user should be able to log out', async () => { | ||
| const page = await context.newPage() | ||
| await page.goto(icelandicAndNoPopupUrl('/samradsgatt')) | ||
|
|
||
| await page.getByRole('button', { name: 'Gervimaður Ameríku' }).click() | ||
| await page.getByRole('button', { name: 'Útskrá' }).click() | ||
| await expect(page.getByTestId('menu-login-btn')).toBeVisible() | ||
|
|
||
| await page.close() | ||
| }) | ||
| }) | ||
|
Comment on lines
+1
to
+139
There was a problem hiding this comment. 💡 Codebase verification Based on the shell script results, I can now provide a final response since I have sufficient information about the test coverage across components. Test coverage improvements needed for critical user flows The current E2E test suite covers basic authenticated flows but lacks coverage for several critical components and scenarios:
Suggested test additions:
🔗 Analysis chainVerify test coverage for critical user flows The test suite covers essential authenticated user flows, but consider adding tests for:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Check for missing test coverage in related components
rg "export|interface|type" apps/consultation-portal/components/ -A 2 | \
while IFS= read -r line; do
if [[ $line =~ "export" ]]; then
component=$(echo "$line" | awk '{print $3}')
echo "Checking test coverage for: $component"
rg "$component" apps/consultation-portal/e2e/ -c || echo "No tests found"
fi
done
Length of output: 63773 |
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add security best practices
Consider enhancing the security of the final image: