feat(web): Forms - datepicker field #17009
Conversation
WalkthroughThe pull request introduces a new date field type to the form component in Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Datadog ReportBranch report: ✅ 0 Failed, 84 Passed, 0 Skipped, 32.35s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17009 +/- ##
=======================================
Coverage 35.60% 35.60%
=======================================
Files 6923 6923
Lines 146304 146316 +12
Branches 41542 41547 +5
=======================================
+ Hits 52096 52101 +5
- Misses 94208 94215 +7 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
apps/web/components/Form/Form.tsx (1)
489-494: Improve date formatting localization.The date formatting implementation could be improved in terms of localization:
- The fallback text "Ekkert svar" should use the localization system.
- Consider using a consistent date format pattern across the application.
Consider applying these improvements:
if (field.type === FormFieldType.DATE) { const date = value ? format(new Date(value), 'do MMMM yyyy') - : 'Ekkert svar' + : n('noAnswer', activeLocale === 'is' ? 'Ekkert svar' : 'No answer') return `${field.title}\nSvar: ${date}\n\n` }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
apps/web/components/Form/Form.tsx(6 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
apps/web/components/Form/Form.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (2)
apps/web/components/Form/Form.tsx (2)
10-10: LGTM! Import statements are properly organized.
The DatePicker component and useDateUtils hook are correctly imported from their respective packages.
Also applies to: 32-32
63-63: LGTM! Enum addition follows consistent pattern.
The DATE field type is properly added to the FormFieldType enum, maintaining consistency with existing field types.
RunarVestmann
added
automerge
* Add datepicker field to forms * Change interval --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Forms - datepicker field
What
Screenshots / Gifs
Checklist:
Summary by CodeRabbit
New Features
Improvements