fix(j-s): Text in infocard

[oddsson]

Summary by CodeRabbit

• New Features

  • Updated internationalization strings for the indictment review process, enhancing clarity and user experience.
  • Modified phrasing for the review tag appeal message to improve comprehension.

• Bug Fixes

  • Incremented version ID for the review tag appeal message to ensure consistency in messaging.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request includes updates to the useInfoCardItems.strings.ts file, specifically modifying internationalization strings used in the judicial system's InfoCard component. Key changes involve updating the message ID for reviewTagAppealed from version 2 to version 3 and altering its default message content. The default message for reviewTagAccepted remains unchanged. These modifications reflect adjustments in the phrasing and versioning of messages related to the indictment review process.

Changes

File Path	Change Summary
apps/judicial-system/web/src/components/InfoCard/useInfoCardItems.strings.ts	- Updated id for reviewTagAppealed from review_tag_appealed_v2 to review_tag_appealed_v3. - Changed defaultMessage for reviewTagAppealed from 'Áfrýja {isFine, select, true {viðurlagaákvörðun} other {dómi}}' to '{isFine, select, true {Kæra viðurlagaákvörðun} other {Áfrýja dómi}}'. - defaultMessage for reviewTagAccepted remains unchanged.

Possibly related PRs

• chore(j-s): Display indictment review decision in correct places #15281: This PR modifies the InfoCard component and includes changes related to the display of indictment review decisions, which connects to the changes made in the useInfoCardItems.strings.ts file regarding the indictment review process.
• feat(j-s): Civil Claimants Info Card #16113: This PR introduces new strings related to civil claimants in the InfoCard component, which aligns with the updates made to the useInfoCardItems.strings.ts file, specifically the addition of civilClaimant and civilClaimants message definitions.
• chore(j-s): Update advocate confirmed strings #16573: Although this PR focuses on updating advocate confirmation strings, it involves changes to localization strings, which is a similar context to the internationalization updates made in the main PR regarding indictment review messages.

Suggested reviewers

• unakb

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.61%. Comparing base (b05c3c6) to head (e2116c5).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17038   +/-   ##
=======================================
  Coverage   35.61%   35.61%           
=======================================
  Files        6933     6933           
  Lines      146837   146837           
  Branches    41745    41745           
=======================================
  Hits        52297    52297           
  Misses      94540    94540           

Flag	Coverage Δ
judicial-system-web	27.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...rc/components/InfoCard/useInfoCardItems.strings.ts	100.00% <ø> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b05c3c6...e2116c5. Read the comment docs.

[datadog-island-is]

Datadog Report

Branch report: j-s/fine-texts
Commit report: 4ffcffd
Test service: judicial-system-web

✅ 0 Failed, 335 Passed, 0 Skipped, 1m 10.29s Total Time
➡️ Test Sessions change in coverage: 1 no change