revert: "chore(ci): revert: Use DOCKER_REGISTRY, and compat" (#17057)"
#17070
Conversation
This reverts commit efa9f05.
WalkthroughThe changes in this pull request focus on updating the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
AndesKrrrrrrrrrrr
added
deploy-feature
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
scripts/ci/Dockerfile (1)
9-9: Consider build cache implicationsThe changes to base image references could invalidate existing build caches in CI/CD pipelines. Ensure that:
- The new registry paths are accessible in all build environments
- Build caches are properly warmed up to maintain build performance
- Image pull permissions are correctly configured for the new registry
Consider implementing a registry fallback mechanism in case the primary registry is unavailable:
-FROM ${DOCKER_REGISTRY}/library/node:${NODE_IMAGE_TAG} AS deps +FROM ${DOCKER_REGISTRY}/library/node:${NODE_IMAGE_TAG} AS deps || FROM node:${NODE_IMAGE_TAG} AS depsAlso applies to: 43-43, 91-91
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
scripts/ci/Dockerfile(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
scripts/ci/Dockerfile (1)
Pattern scripts/**/*: "Confirm that the code adheres to the following:
- Script efficiency, readability, and maintainability.
- Usage of environmental variables and configuration files for flexibility.
- Integration with NX workspace utilities and commands."
🔇 Additional comments (2)
scripts/ci/Dockerfile (2)
3-6: Verify if this change aligns with revert intention
The current changes introduce a new registry handling approach that might not align with the PR's revert intention. The string manipulation in ${DOCKER_ECR_REGISTRY%/docker} could be fragile if the registry path structure changes.
Line range hint 1-180: Verify complete revert implementation
This implementation appears to introduce new complexity rather than simply reverting the changes from PR #17057. A clean revert should restore the exact previous state.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17070 +/- ##
==========================================
- Coverage 35.69% 35.69% -0.01%
==========================================
Files 6938 6938
Lines 147105 147105
Branches 41822 41822
==========================================
- Hits 52516 52515 -1
- Misses 94589 94590 +1 Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 99 Total Test Services: 0 Failed, 91 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (2) |
This reverts commit efa9f05.
See #17057
Summary by CodeRabbit