feat(j-s): Set court session type to arraignment when subpoena created #17209
Conversation
So that it can be displayed in more detail on in the case Table
WalkthroughThe changes in this pull request focus on the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
apps/judicial-system/web/src/routes/Court/Indictments/Subpoena/Subpoena.tsx (2)
85-102: Consider enforcing arraignment type through TypeScriptWhile the implementation correctly sets the court session type to arraignment, the comment "This should always be an arraignment type" suggests this business rule could be better enforced through TypeScript.
Consider creating a specific type for the updates:
type SubpoenaCourtUpdate = { courtSessionType: CourtSessionType.ARRAIGNMENT; indictmentDecision?: null; courtDate?: null; postponedIndefinitelyExplanation?: null; indictmentRulingDecision?: null; mergeCaseId?: null; force?: boolean; };
91-101: Extract conditional logic into a separate functionThe conditional clearing of fields when rescheduling after court has met would be more maintainable if extracted into a separate function.
Consider refactoring like this:
const getClearanceFields = ( isArraignmentScheduled: boolean, hasIndictmentDecision: boolean, ) => { if (!isArraignmentScheduled || !hasIndictmentDecision) { return {}; } return { indictmentDecision: null, courtDate: null, postponedIndefinitelyExplanation: null, indictmentRulingDecision: null, mergeCaseId: null, force: true, }; }; const additionalUpdates = [{ courtSessionType: CourtSessionType.ARRAIGNMENT, ...getClearanceFields(isArraignmentScheduled, Boolean(workingCase.indictmentDecision)), }];
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
apps/judicial-system/web/src/routes/Court/Indictments/Subpoena/Subpoena.tsx(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
apps/judicial-system/web/src/routes/Court/Indictments/Subpoena/Subpoena.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (1)
apps/judicial-system/web/src/routes/Court/Indictments/Subpoena/Subpoena.tsx (1)
8-8: LGTM: Clean type import
The import of CourtSessionType from the shared types package follows TypeScript best practices and maintains type safety across the application.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17209 +/- ##
==========================================
- Coverage 35.71% 35.71% -0.01%
==========================================
Files 6944 6944
Lines 148501 148486 -15
Branches 42383 42378 -5
==========================================
- Hits 53043 53026 -17
- Misses 95458 95460 +2 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 29 Total Test Services: 0 Failed, 26 Passed Test ServicesThis report shows up to 10 services
|
oddsson
added
automerge
So that it can be displayed in more detail on in the case Table
Á dagskrá -> Þingfesting
What
Set court session type to arraignment when sending subpoenas
Why
Because that is the court session type being registered, and so we can display it correctly in the active case table
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes