fix: search indexer service scaling on staging

[brynjarorng]

Search indexer scaling

This service should only at max have 1 containers running so this is a special edge case that needs to be dealt with.

Summary by CodeRabbit

• New Features

  • Enhanced database migration process with new initialization scripts for services.
  • Standardized health check paths for improved monitoring.

• Bug Fixes

  • Adjusted resource allocation and scaling settings for search-indexer-service and services-university-gateway.

• Chores

  • Updated environment variables and resource settings for better performance and resource management.

[coderabbitai]

Walkthrough

The changes in this pull request primarily involve modifications to the configuration files for the search-indexer-service and services-university-gateway. Key adjustments include reducing the replicaCount and Horizontal Pod Autoscaler (HPA) settings from a maximum of 3 to 1, updating initContainer configurations to include migration scripts, and standardizing health check paths. Additionally, the resources section for the search-indexer-service has been modified to increase memory limits, reflecting a shift in resource allocation and service initialization processes.

Changes

File Path	Change Summary
charts/islandis/values.staging.yaml	Reduced replicaCount and HPA settings from 3 to 1 for search-indexer-service and services-university-gateway. Added migration scripts in initContainer. Standardized health check paths to /liveness. Increased memory limits in resources for search-indexer-service.
charts/services/search-indexer-service/values.staging.yaml	Adjusted HPA and replicaCount settings from 3 to 1. Updated NODE_OPTIONS in initContainer to reduce maximum old space size from 3686 to 2048. Set podDisruptionBudget to allow 1 unavailable pod.
infra/src/dsl/output-generators/map-to-helm-values.ts	Modified serializeService function to exclude search-indexer services from the default replicaCount logic in the staging environment.

Possibly related PRs

• chore: Rightsizing some services #15944: Modifies the replicaCount settings for services, directly related to changes in this PR.
• fix: Scaling issues with web due to low CPU limits #15955: Adjusts CPU limits and requests in the values.staging.yaml, aligning with resource allocation changes in this PR.
• fix(search-indexer): Disable global auth on dev and staging #16443: Updates the initContainer for the search-indexer service to include migration scripts, relevant to this PR's changes.
• chore(application-system): Increase cpu and mem limit and request to avoid crashloops #16792: Increases CPU and memory limits for the application-system-api, relevant to resource allocation adjustments in this PR.
• chore(application-system): Set initialDelay to 20 seconds #16893: Modifies health check parameters, consistent with health check standardization changes in this PR.
• fix(search-indexer): Stop refreshing index immediately #17069: Addresses changes in the IndexingService related to the search indexer, connecting to the focus of this PR.

Suggested labels

automerge

Suggested reviewers

• thordurhhh
• Toti91

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 55aae3d and 33302bd.

📒 Files selected for processing (3)

• charts/islandis/values.staging.yaml (2 hunks)
• charts/services/search-indexer-service/values.staging.yaml (2 hunks)
• infra/src/dsl/output-generators/map-to-helm-values.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

infra/src/dsl/output-generators/map-to-helm-values.ts (1)

Pattern infra/src/dsl/**/*: "Confirm that the code adheres to the following:

• The clarity and expressiveness of the DSL syntax.
• Integration with Helm charts and Kubernetes resources.
• Documentation on how to use the DSL to create complex Helm values."

🔇 Additional comments (5)

charts/services/search-indexer-service/values.staging.yaml (2)

52-52: LGTM: HPA scaling max replicas set to 1

The change ensures that the Horizontal Pod Autoscaler (HPA) will maintain exactly one replica of the search indexer service, which aligns with the requirement that only one container should run at any time.

---

130-130: LGTM: replicaCount max set to 1

The change ensures consistent configuration with the HPA settings, maintaining a single replica count maximum. This is the correct approach for services that must run as singletons.

infra/src/dsl/output-generators/map-to-helm-values.ts (1)

112-112: LGTM: Exclude search-indexer from default staging replica count

The condition service.name.indexOf('search-indexer') == -1 correctly excludes the search indexer service from getting the default staging replica count of 3, ensuring it maintains its specific configuration of max 1 replica.

charts/islandis/values.staging.yaml (2)

1745-1745: LGTM: HPA scaling max replicas set to 1

The change ensures consistent HPA configuration across all deployment files, maintaining the single container requirement for the search indexer service.

---

1823-1823: LGTM: replicaCount max set to 1

The change ensures consistent replica count configuration across all deployment files, maintaining the single container requirement for the search indexer service.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[robertaandersen]

LGTM

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.71%. Comparing base (e9edeb3) to head (8bf471e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17234   +/-   ##
=======================================
  Coverage   35.71%   35.71%           
=======================================
  Files        6944     6944           
  Lines      148537   148537           
  Branches    42405    42405           
=======================================
  Hits        53047    53047           
  Misses      95490    95490           

Flag	Coverage Δ
api	3.33% <ø> (ø)
api-domains-auth-admin	48.49% <ø> (ø)
api-domains-communications	39.42% <ø> (ø)
application-system-api	38.74% <ø> (+<0.01%)	⬆️
application-template-api-modules	27.82% <ø> (+0.01%)	⬆️
application-templates-accident-notification	28.82% <ø> (ø)
application-templates-car-recycling	3.12% <ø> (ø)
application-templates-driving-license	18.16% <ø> (ø)
application-templates-estate	13.69% <ø> (ø)
application-templates-financial-aid	14.46% <ø> (ø)
application-templates-general-petition	23.15% <ø> (ø)
application-templates-inheritance-report	6.59% <ø> (ø)
application-templates-marriage-conditions	15.19% <ø> (ø)
application-templates-mortgage-certificate	43.64% <ø> (ø)
application-templates-parental-leave	29.94% <ø> (ø)
application-ui-components	1.22% <ø> (ø)
application-ui-shell	22.32% <ø> (ø)
cms	0.39% <ø> (ø)
cms-translations	38.75% <ø> (ø)
judicial-system-api	20.21% <ø> (ø)
judicial-system-backend	55.91% <ø> (ø)
services-user-notification	46.54% <ø> (ø)
shared-form-fields	33.36% <ø> (ø)
web	2.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9edeb3...8bf471e. Read the comment docs.