Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(samgongustofa): shared vehicle select form field #17237

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

johannaagma
Copy link
Member

What

Creating a shared Vehicle Select Form Field to use in all SGS applications where you are selecting vehicle/plate, since we are currently creating very similar custom components for this. (Note: is also very similar in all the AOSH applications, could look into updating them to use this shared field as well after this PR)

In some cases we have fixed bugs in some of these custom components, but not all, so having it all in one place makes it easier when fixing/adding to this select field

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Copy link
Contributor

coderabbitai bot commented Dec 13, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 3.29218% with 235 lines in your changes missing coverage. Please review.

Project coverage is 35.70%. Comparing base (28c639f) to head (a26396e).

Files with missing lines Patch % Lines
.../VehicleSelectFormField/VehicleSelectFormField.tsx 0.64% 154 Missing ⚠️
.../ui-fields/src/lib/VehicleSelectFormField/utils.ts 10.25% 35 Missing ⚠️
...ib/VehicleRadioFormField/VehicleRadioFormField.tsx 0.00% 30 Missing ⚠️
...ib/modules/shared/api/vehicles/vehicles.service.ts 0.00% 11 Missing ⚠️
...n/ui-fields/src/lib/VehicleRadioFormField/utils.ts 16.66% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17237      +/-   ##
==========================================
- Coverage   35.74%   35.70%   -0.05%     
==========================================
  Files        6937     6940       +3     
  Lines      148177   148373     +196     
  Branches    42254    42377     +123     
==========================================
+ Hits        52969    52977       +8     
- Misses      95208    95396     +188     
Flag Coverage Δ
air-discount-scheme-web 0.00% <ø> (ø)
api 3.33% <ø> (ø)
application-api-files 61.93% <100.00%> (+0.06%) ⬆️
application-core 75.81% <100.00%> (+0.03%) ⬆️
application-system-api 38.74% <15.38%> (+<0.01%) ⬆️
application-template-api-modules 27.81% <15.38%> (+<0.01%) ⬆️
application-templates-accident-notification 28.82% <ø> (ø)
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-criminal-record 25.77% <ø> (ø)
application-templates-driving-license 18.16% <ø> (ø)
application-templates-estate 13.80% <ø> (ø)
application-templates-example-payment 24.72% <ø> (ø)
application-templates-financial-aid 14.46% <ø> (ø)
application-templates-general-petition 23.15% <ø> (ø)
application-templates-inheritance-report 6.59% <ø> (ø)
application-templates-marriage-conditions 15.19% <ø> (ø)
application-templates-mortgage-certificate 43.70% <100.00%> (+0.05%) ⬆️
application-templates-parental-leave 29.94% <ø> (ø)
application-types 6.48% <0.00%> (-0.03%) ⬇️
application-ui-components 1.24% <ø> (ø)
application-ui-shell 22.08% <2.60%> (-0.44%) ⬇️
clients-charge-fjs-v2 28.35% <ø> (ø)
web 2.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
libs/application/types/src/lib/Fields.ts 100.00% <100.00%> (ø)
.../lib/FindVehicleFormField/FindVehicleFormField.tsx 2.19% <ø> (+0.01%) ⬆️
...n/ui-fields/src/lib/VehicleRadioFormField/utils.ts 16.66% <16.66%> (ø)
...ib/modules/shared/api/vehicles/vehicles.service.ts 26.47% <0.00%> (-3.53%) ⬇️
...ib/VehicleRadioFormField/VehicleRadioFormField.tsx 1.05% <0.00%> (+0.08%) ⬆️
.../ui-fields/src/lib/VehicleSelectFormField/utils.ts 10.25% <10.25%> (ø)
.../VehicleSelectFormField/VehicleSelectFormField.tsx 0.64% <0.64%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28c639f...a26396e. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

All test runs 486c69c 🔗

21 Total Test Services: 0 Failed, 20 Passed
🔻 Test Sessions change in coverage: 2 decreased, 4 increased, 87 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-web 0 0 0 2 0 6.63s 1 no change Link
api 0 0 0 4 0 2.46s 1 no change Link
application-api-files 0 0 0 2 0 4.29s 1 increased (+0.07%) Link
application-core 0 0 0 97 0 15.11s 1 increased (+0.03%) Link
application-system-api 0 0 0 46 0 2m 15.04s 1 no change Link
application-template-api-modules 0 0 0 118 0 2m 5.99s 1 increased (+0.01%) Link
application-templates-accident-notification 0 0 0 148 0 14.68s 1 no change Link
application-templates-criminal-record 0 0 0 2 0 9.41s 1 no change Link
application-templates-driving-license 0 0 0 13 0 12.76s 1 no change Link
application-templates-example-payment 0 0 0 2 0 9.96s 1 no change Link

🔻 Code Coverage Decreases vs Default Branch (2)

  • application-ui-shell - jest 28.97% (-0.44%) - Details
  • application-types - jest 5.36% (-0.02%) - Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant