Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(native-app): add english translations for organ donation in app #17259

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

thoreyjona
Copy link
Contributor

@thoreyjona thoreyjona commented Dec 16, 2024

English translations were missing but now they are ready for the service portal so I used the same ones that are there.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features
    • Updated English translations for organ donation-related messages to enhance clarity and accuracy.
  • Version Updates
    • Incremented application version from 1.4.8 to 1.4.9 for both Android and iOS platforms.

@thoreyjona thoreyjona requested a review from a team as a code owner December 16, 2024 15:13
Copy link
Contributor

coderabbitai bot commented Dec 16, 2024

Walkthrough

This pull request focuses on updating English language translations in the apps/native/app/src/messages/en.ts file, specifically for organ donation-related messages. The changes involve refining the text to provide more precise and clear translations of various statements about organ donation, such as changing selection, donor status, and organ usage permissions. Additionally, the version number for the Android and iOS applications has been incremented from 1.4.8 to 1.4.9 in their respective configuration files.

Changes

File Change Summary
apps/native/app/src/messages/en.ts Updated multiple organ donation-related translation strings, including:
- "Change selection" instead of "Breyta afstöðu"
- "I am an organ donor"
- Revised statements about organ donation permissions and limitations
apps/native/app/android/app/build.gradle Updated versionName from "1.4.8" to "1.4.9" in android.defaultConfig
apps/native/app/ios/IslandApp/Info.plist Updated CFBundleShortVersionString from 1.4.8 to 1.4.9

Possibly related PRs

  • feat(native-app): add organ donation to app #16401: This PR adds organ donation features to the app, including updates to the en.ts file for English translations related to organ donation, which directly relates to the changes made in the main PR that also updates organ donation-related messages in en.ts.
  • fix(my-pages): add locale param to oragn donation query #16465: This PR adds a locale parameter to the organ donation query, which is relevant as it enhances the functionality of the organ donation feature, aligning with the updates made in the main PR regarding organ donation translations.
  • fix(native-app): change Payments to Co-payments #16403: This PR modifies the en.ts file by changing the key for payments to co-payments, which is related to the overall updates in the en.ts file in the main PR that focuses on organ donation messages.

Suggested labels

automerge

Suggested reviewers

  • snaerseljan

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@snaerth snaerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thoreyjona thoreyjona added automerge Merge this PR as soon as all checks pass and removed automerge Merge this PR as soon as all checks pass labels Dec 16, 2024
@thoreyjona thoreyjona added the automerge Merge this PR as soon as all checks pass label Dec 16, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between acd2793 and a9fc25a.

📒 Files selected for processing (2)
  • apps/native/app/android/app/build.gradle (1 hunks)
  • apps/native/app/ios/IslandApp/Info.plist (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
apps/native/app/ios/IslandApp/Info.plist (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
apps/native/app/android/app/build.gradle (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (1)
apps/native/app/ios/IslandApp/Info.plist (1)

20-20: LGTM! Verify version consistency across platforms.

The version bump from 1.4.8 to 1.4.9 is appropriate for the feature addition.

Let's verify version consistency across Android and iOS configurations:

✅ Verification successful

Version numbers are consistent across iOS and Android platforms

The version number 1.4.9 is correctly synchronized between:

  • iOS: CFBundleShortVersionString = 1.4.9 (Info.plist)
  • Android: versionName = 1.4.9 (build.gradle)
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check version numbers across Android and iOS configurations
echo "iOS version (Info.plist):"
grep -A 1 "CFBundleShortVersionString" apps/native/app/ios/IslandApp/Info.plist

echo -e "\nAndroid version (build.gradle):"
grep "versionName" apps/native/app/android/app/build.gradle

Length of output: 370

apps/native/app/android/app/build.gradle Show resolved Hide resolved
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.71%. Comparing base (4c04e19) to head (a395025).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17259      +/-   ##
==========================================
- Coverage   35.71%   35.71%   -0.01%     
==========================================
  Files        6944     6944              
  Lines      148537   148537              
  Branches    42405    42405              
==========================================
- Hits        53049    53047       -2     
- Misses      95488    95490       +2     
Flag Coverage Δ
api 3.33% <ø> (ø)
api-domains-auth-admin 48.49% <ø> (ø)
api-domains-communications 39.42% <ø> (ø)
application-system-api 38.73% <ø> (-0.02%) ⬇️
application-template-api-modules 27.83% <ø> (ø)
application-templates-accident-notification 28.82% <ø> (ø)
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-driving-license 18.16% <ø> (ø)
application-templates-estate 13.69% <ø> (ø)
application-templates-financial-aid 14.46% <ø> (ø)
application-templates-general-petition 23.15% <ø> (ø)
application-templates-inheritance-report 6.59% <ø> (ø)
application-templates-marriage-conditions 15.19% <ø> (ø)
application-templates-mortgage-certificate 43.64% <ø> (ø)
application-templates-parental-leave 29.94% <ø> (ø)
application-ui-components 1.22% <ø> (ø)
application-ui-shell 22.32% <ø> (ø)
cms 0.39% <ø> (ø)
cms-translations 38.75% <ø> (ø)
judicial-system-api 20.21% <ø> (ø)
judicial-system-backend 55.91% <ø> (-0.01%) ⬇️
services-user-notification 46.52% <ø> (-0.03%) ⬇️
shared-form-fields 33.36% <ø> (ø)
web 2.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c04e19...a395025. Read the comment docs.

@kodiakhq kodiakhq bot merged commit e9edeb3 into main Dec 18, 2024
108 checks passed
@kodiakhq kodiakhq bot deleted the feat/add-translations-for-organ-donation branch December 18, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants