-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(native-app): add english translations for organ donation in app #17259
Conversation
WalkthroughThis pull request focuses on updating English language translations in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/native/app/android/app/build.gradle
(1 hunks)apps/native/app/ios/IslandApp/Info.plist
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
apps/native/app/ios/IslandApp/Info.plist (1)
Pattern apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/native/app/android/app/build.gradle (1)
Pattern apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (1)
apps/native/app/ios/IslandApp/Info.plist (1)
20-20
: LGTM! Verify version consistency across platforms.
The version bump from 1.4.8 to 1.4.9 is appropriate for the feature addition.
Let's verify version consistency across Android and iOS configurations:
✅ Verification successful
Version numbers are consistent across iOS and Android platforms
The version number 1.4.9 is correctly synchronized between:
- iOS: CFBundleShortVersionString = 1.4.9 (Info.plist)
- Android: versionName = 1.4.9 (build.gradle)
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check version numbers across Android and iOS configurations
echo "iOS version (Info.plist):"
grep -A 1 "CFBundleShortVersionString" apps/native/app/ios/IslandApp/Info.plist
echo -e "\nAndroid version (build.gradle):"
grep "versionName" apps/native/app/android/app/build.gradle
Length of output: 370
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17259 +/- ##
==========================================
- Coverage 35.71% 35.71% -0.01%
==========================================
Files 6944 6944
Lines 148537 148537
Branches 42405 42405
==========================================
- Hits 53049 53047 -2
- Misses 95488 95490 +2 Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
English translations were missing but now they are ready for the service portal so I used the same ones that are there.
Checklist:
Summary by CodeRabbit