feat(web): Article Institution Panel - Read eyebrow text from org namespace #17292
Conversation
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
warning eslint@8.57.0: This version is no longer supported. Please see https://eslint.org/version-support for other options. WalkthroughThe pull request modifies the Changes
Suggested reviewers
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17292 +/- ##
==========================================
- Coverage 35.70% 35.69% -0.02%
==========================================
Files 6923 6922 -1
Lines 148599 148497 -102
Branches 42452 42412 -40
==========================================
- Hits 53058 53000 -58
+ Misses 95541 95497 -44
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 19 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/web/screens/Article/Article.tsx (1)
265-265: Consider using React Context to avoid prop drillingThe
organizationNamespaceprop is being passed down through multiple levels of components. Consider using React Context to manage this shared state and avoid prop drilling.+import { createContext, useContext } from 'react' + +export const OrganizationNamespaceContext = createContext<Record<string, string>>({}) + +export const OrganizationNamespaceProvider: FC<{ + organizationNamespace: Record<string, string> + children: React.ReactNode +}> = ({ organizationNamespace, children }) => ( + <OrganizationNamespaceContext.Provider value={organizationNamespace}> + {children} + </OrganizationNamespaceContext.Provider> +) + +export const useOrganizationNamespace = () => useContext(OrganizationNamespaceContext)Also applies to: 272-272, 319-319, 631-631, 664-664, 791-791
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/web/screens/Article/Article.tsx(9 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
apps/web/screens/Article/Article.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (1)
apps/web/screens/Article/Article.tsx (1)
928-928: LGTM: Proper type handling in getProps
The extraction and typing of organizationNamespace in getProps is well implemented with proper type assertions.
Also applies to: 936-936
Datadog ReportBranch report: ✅ 0 Failed, 84 Passed, 0 Skipped, 24.14s Total Time |
kodiakhq
bot
deleted the
feature/web-article-institution-panel-custom-eyebrow-text
branch
Article Institution Panel - Read eyebrow text from org namespace
Screenshots / Gifs
Before
After
Checklist:
Summary by CodeRabbit
New Features
organizationNamespaceproperty.Bug Fixes
Documentation
organizationNamespaceproperty.