Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Hotfix - My pages links for directorate of labour #17444

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

RunarVestmann
Copy link
Member

Hotfix - My pages links for directorate of labour

#17353

@RunarVestmann RunarVestmann added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Jan 8, 2025
@RunarVestmann RunarVestmann requested review from a team as code owners January 8, 2025 12:26
Copy link
Contributor

coderabbitai bot commented Jan 8, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 3.70370% with 26 lines in your changes missing coverage. Please review.

Project coverage is 35.70%. Comparing base (bec763d) to head (ba5c6bc).
Report is 1 commits behind head on release/33.2.0.

Files with missing lines Patch % Lines
...reens/Organization/DirectorateOfLabour/MyPages.tsx 0.00% 21 Missing ⚠️
...pages/en/o/directorate-of-labour/my-pages/index.ts 0.00% 2 Missing ⚠️
.../web/pages/s/vinnumalastofnun/minar-sidur/index.ts 0.00% 2 Missing ⚠️
...rganization/DirectorateOfLabour/MyPages.strings.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/33.2.0   #17444      +/-   ##
==================================================
- Coverage           35.70%   35.70%   -0.01%     
==================================================
  Files                6931     6935       +4     
  Lines              147989   148014      +25     
  Branches            42205    42213       +8     
==================================================
+ Hits                52844    52845       +1     
- Misses              95145    95169      +24     
Flag Coverage Δ
judicial-system-backend 55.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/web/hooks/useLinkResolver/useLinkResolver.ts 72.13% <ø> (ø)
libs/shared/types/src/lib/api-cms-domain.ts 100.00% <100.00%> (ø)
...rganization/DirectorateOfLabour/MyPages.strings.ts 0.00% <0.00%> (ø)
...pages/en/o/directorate-of-labour/my-pages/index.ts 0.00% <0.00%> (ø)
.../web/pages/s/vinnumalastofnun/minar-sidur/index.ts 0.00% <0.00%> (ø)
...reens/Organization/DirectorateOfLabour/MyPages.tsx 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bec763d...ba5c6bc. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Jan 8, 2025

Datadog Report

All test runs 5facc8d 🔗

10 Total Test Services: 0 Failed, 10 Passed
🔻 Test Sessions change in coverage: 16 decreased, 26 increased, 158 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-backend 0 0 0 63 0 28.96s N/A Link
air-discount-scheme-web 0 0 0 2 0 7s N/A Link
api 0 0 0 4 0 2.36s N/A Link
api-domains-air-discount-scheme 0 0 0 6 0 15.75s N/A Link
api-domains-assets 0 0 0 3 0 9.97s N/A Link
api-domains-auth-admin 0 0 0 18 0 10.01s N/A Link
api-domains-communications 0 0 0 5 0 29.37s 1 increased (+0.02%) Link
api-domains-criminal-record 0 0 0 5 0 8.51s N/A Link
api-domains-driving-license 0 0 0 23 0 26.3s 1 decreased (-0.02%) Link
api-domains-education 0 0 0 8 0 18.46s N/A Link

🔻 Code Coverage Decreases vs Default Branch (16)

This report shows up to 5 code coverage decreases.

  • clients-financial-statements-inao - jest 49.75% (-2.19%) - Details
  • judicial-system-xrd-api - jest 74.63% (-0.2%) - Details
  • application-templates-marriage-conditions - jest 19.78% (-0.16%) - Details
  • application-templates-mortgage-certificate - jest 52.62% (-0.13%) - Details
  • application-templates-parental-leave - jest 34.95% (-0.11%) - Details

@RunarVestmann RunarVestmann removed the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Jan 8, 2025
@RunarVestmann RunarVestmann added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Jan 8, 2025
@kodiakhq kodiakhq bot merged commit d4c3c8e into release/33.2.0 Jan 8, 2025
221 of 230 checks passed
@kodiakhq kodiakhq bot deleted the hotfix/web-vmst-my-pages branch January 8, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated:automerge (Disabled) Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants