-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client-driving-license): Hotfix - Leap year edge issues (#17415) #17445
fix(client-driving-license): Hotfix - Leap year edge issues (#17415) #17445
Conversation
* fix(clients-driving-license): Compute 365 days as a constant to avoid leap year issues * Conform tests for non-leap-days * Fix driving license residency check test * Prevent rewrites with a comment * Fix import --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/33.2.0 #17445 +/- ##
===============================================
Coverage 35.70% 35.70%
===============================================
Files 6931 6931
Lines 147993 147989 -4
Branches 42207 42205 -2
===============================================
Hits 52844 52844
+ Misses 95149 95145 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 4 Total Test Services: 0 Failed, 4 Passed Test Services
🔻 Code Coverage Decreases vs Default Branch (2) |
Hotfix - Leap year edge issues (#17415)
So other changes can be hotfixed I suggest we hotfix this fix for a broken unit test