feat(j-s): Merge case with another that is not in RVG #17516
Conversation
WalkthroughThis pull request introduces modifications to several components in the judicial system web application, focusing on enhancing case management and select component functionality. The changes include refactoring the Changes
Sequence DiagramsequenceDiagram
participant User
participant ConclusionComponent
participant SelectConnectedCase
participant ValidationUtility
User->>ConclusionComponent: Enter merge case number
ConclusionComponent->>ValidationUtility: Validate merge case number
ValidationUtility-->>ConclusionComponent: Validation result
ConclusionComponent->>SelectConnectedCase: Update connected case selection
SelectConnectedCase->>ConclusionComponent: Confirm case merge
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Datadog ReportAll test runs ✅ 10 Total Test Services: 0 Failed, 10 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (3) |
…b.com:island-is/island.is into j-s/merge-outside-fe
oddsson
changed the title
…s/show-merged-case-number-outside-of-system
…://github.com/island-is/island.is into j-s/show-merged-case-number-outside-of-system
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (2)
libs/island-ui/core/src/lib/Select/Select.tsx (1)
Line range hint
120-124: Consider adding ARIA labels for clear button.The ClearIndicator should have appropriate ARIA labels to improve accessibility.
ClearIndicator, +// Add to ClearIndicator component: +aria-label="Clear selection" +role="button"apps/judicial-system/web/src/components/CourtDocuments/CourtDocuments.tsx (1)
Line range hint
45-67: Add error handling for document operations.The document manipulation functions (
handleRemoveDocument,handleAddDocument,handleSubmittedBy) should include error handling for failed operations.const handleAddDocument = (document: string) => { + try { const updatedCourtDocuments = [ ...(workingCase.courtDocuments || []), { name: document, submittedBy: undefined }, ] setUpdateIndex(undefined) setAndSendCaseToServer( [{ courtDocuments: updatedCourtDocuments, force: true }], workingCase, setWorkingCase, - ) + ).catch((error) => { + // Handle error appropriately + console.error('Failed to add document:', error); + }) + } catch (error) { + console.error('Error processing document:', error); + } }
🧹 Nitpick comments (7)
apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/SelectConnectedCase.tsx (2)
40-40: Consider adding JSDoc for the setConnectedCase function.Adding documentation for the function's behavior when handling null values would improve maintainability.
+/** + * Sets the connected case ID in the working case state. + * @param connectedCaseId - The ID of the case to connect, or null to clear the connection + */ const setConnectedCase = async (connectedCaseId: string | null) => {Also applies to: 43-43
70-111: Improve readability by extracting rendering conditions.The nested conditional rendering could be simplified by extracting the conditions into named variables or separate render methods.
+const renderLoadingState = () => ( + <Box textAlign="center" paddingY={2} paddingX={3} marginBottom={2} key="loading-dots"> + <LoadingDots /> + </Box> +) + +const renderWarningMessage = (title: string, message: string) => ( + <AlertMessage type="warning" title={title} message={message} /> +) + +const renderSelect = () => ( + <Select + name="connectedCase" + label={formatMessage(strings.connectedCaseLabel)} + options={connectedCases} + value={defaultConnectedCase} + placeholder={formatMessage(strings.connectedCasePlaceholder)} + onChange={(selectedOption) => { + setConnectedCase((selectedOption?.value as string) || null) + }} + isDisabled={connectedCasesLoading || Boolean(mergeCaseNumber)} + isClearable + /> +) if (!mergeAllowed) { - return ( - <AlertMessage - type="warning" - title={formatMessage(strings.cannotBeMergedTitle)} - message={formatMessage(strings.cannotBeMergedMessage)} - /> - ) + return renderWarningMessage( + formatMessage(strings.cannotBeMergedTitle), + formatMessage(strings.cannotBeMergedMessage) + ) } else if (connectedCasesLoading) { - return ( - <Box textAlign="center" paddingY={2} paddingX={3} marginBottom={2} key="loading-dots"> - <LoadingDots /> - </Box> - ) + return renderLoadingState() } else { return connectedCases.length === 0 ? ( - <AlertMessage - type="warning" - title={formatMessage(strings.noConnectedCasesTitle)} - message={formatMessage(strings.noConnectedCasesMessage)} - /> + renderWarningMessage( + formatMessage(strings.noConnectedCasesTitle), + formatMessage(strings.noConnectedCasesMessage) + ) ) : ( - <Select - name="connectedCase" - label={formatMessage(strings.connectedCaseLabel)} - options={connectedCases} - value={defaultConnectedCase} - placeholder={formatMessage(strings.connectedCasePlaceholder)} - onChange={(selectedOption) => { - setConnectedCase((selectedOption?.value as string) || null) - }} - isDisabled={connectedCasesLoading || Boolean(mergeCaseNumber)} - isClearable - /> + renderSelect() ) }apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/Conclusion.tsx (2)
233-237: Consider adding cleanup in useEffect.The effect hook should clean up when the component unmounts.
useEffect(() => { if (workingCase.mergeCaseNumber) { setMergeCaseNumber(workingCase.mergeCaseNumber) } + return () => { + setMergeCaseNumber(undefined) + } }, [workingCase.mergeCaseNumber])
239-245: Consider extracting validation logic to a custom hook.The validation logic could be reusable across components.
+const useCaseNumberValidation = () => { + const validateCaseNumber = (value: string) => { + const validation = validate([[value, ['S-case-number']]]) + return { + isValid: validation.isValid, + errorMessage: validation.isValid ? undefined : validation.errorMessage, + } + } + return validateCaseNumber +} -const handleMergeCaseNumberBlur = (value: string) => { - const validation = validate([[value, ['S-case-number']]]) - - setMergeCaseNumberErrorMessage( - validation.isValid ? undefined : validation.errorMessage, - ) -} +const validateCaseNumber = useCaseNumberValidation() +const handleMergeCaseNumberBlur = (value: string) => { + const { errorMessage } = validateCaseNumber(value) + setMergeCaseNumberErrorMessage(errorMessage) +}apps/judicial-system/web/src/components/SelectComponents/SelectComponents.tsx (1)
1-47: Consider grouping related components in a styled-components pattern.The components share similar patterns and styling approaches. Consider organizing them using styled-components to reduce repetition and improve maintainability.
Example refactor:
const StyledText = styled(Text)` // shared text styles ` const SelectComponent = { DropdownIndicator: (props: DropdownIndicatorProps<ReactSelectOption>) => ( <components.DropdownIndicator {...props}> <Icon type="cheveron" width={12} height={12} color="blue400" /> </components.DropdownIndicator> ), // ... other components following the same pattern } export const { DropdownIndicator, Placeholder, SingleValue, Option } = SelectComponentapps/judicial-system/web/src/components/CourtDocuments/CourtDocuments.tsx (2)
Line range hint
144-207: Extract inline styles to a separate styles object or file.The select component contains complex inline styles that would be better maintained in a separate styles object or file.
Example:
// selectStyles.ts export const selectStyles = { control: (baseStyles) => ({ ...baseStyles, border: 'none', // ... other control styles }), // ... other style objects } // In component: styles={selectStyles}
Line range hint
31-33: Optimize state management with useCallback.The state management for
submittedByMenuIsOpenandupdateIndexcould be optimized usinguseCallbackto prevent unnecessary rerenders.+import { useCallback } from 'react'; + const CourtDocuments: FC<Props> = ({ workingCase, setWorkingCase }) => { - const [submittedByMenuIsOpen, setSubmittedByMenuIsOpen] = useState<number>(-1) - const [updateIndex, setUpdateIndex] = useState<number | undefined>(undefined) + const [submittedByMenuIsOpen, setSubmittedByMenuIsOpen] = useState<number>(-1); + const [updateIndex, setUpdateIndex] = useState<number | undefined>(undefined); + + const handleMenuOpen = useCallback((index: number) => { + setSubmittedByMenuIsOpen(index); + }, []);
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
apps/judicial-system/web/src/components/CourtDocuments/CourtDocuments.tsx(2 hunks)apps/judicial-system/web/src/components/SelectComponents/SelectComponents.tsx(1 hunks)apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/Conclusion.strings.ts(1 hunks)apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/Conclusion.tsx(7 hunks)apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/SelectConnectedCase.tsx(3 hunks)libs/island-ui/core/src/lib/Select/Select.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (6)
apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/Conclusion.strings.ts (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/SelectComponents/SelectComponents.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/CourtDocuments/CourtDocuments.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/Conclusion.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
libs/island-ui/core/src/lib/Select/Select.tsx (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/SelectConnectedCase.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
📓 Learnings (1)
apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/Conclusion.tsx (1)
Learnt from: unakb
PR: island-is/island.is#15378
File: apps/judicial-system/web/src/routes/Court/Indictments/Summary/Summary.tsx:86-100
Timestamp: 2024-11-12T15:15:11.835Z
Learning: User unakb prefers explicit case handling in switch statements for key functionalities like `getRulingDecisionTagColor` to ensure clarity and avoid assumptions that a case was overlooked.
🔇 Additional comments (6)
apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/SelectConnectedCase.tsx (2)
21-21: LGTM! Well-typed prop definition.The optional
mergeCaseNumberprop is properly typed with TypeScript, allowing for both string and null values.
24-28: LGTM! Clean component parameter destructuring.The component parameters are well-structured and follow React best practices.
apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/Conclusion.strings.ts (1)
102-113: LGTM! Well-structured message definitions.The new messages for merge case number functionality are properly defined with clear IDs, default messages, and helpful descriptions.
apps/judicial-system/web/src/routes/Court/Indictments/Conclusion/Conclusion.tsx (2)
110-112: LGTM! Clean state management implementation.The state variables for merge case number and error message are well-defined using React hooks.
533-560: LGTM! Well-structured form implementation.The form elements are properly organized with appropriate error handling and user feedback.
libs/island-ui/core/src/lib/Select/Select.tsx (1)
120-120: Verify ClearIndicator behavior across select variants.The ClearIndicator is added to both select variants. Ensure consistent behavior between CreatableReactSelect and ReactSelect, especially with keyboard navigation and screen readers.
✅ Verification successful
ClearIndicator implementation follows accessibility best practices
The ClearIndicator is properly integrated with react-select's base implementation, which includes built-in keyboard navigation and screen reader support. The component is consistently implemented across both select variants with proper ARIA attributes for error states and announcements.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for any existing accessibility-related tests rg -l "accessibility|aria|screen.?reader" --type ts --type tsxLength of output: 92
Script:
#!/bin/bash # Find TypeScript files and search for accessibility patterns fd -e ts -e tsx | xargs rg -l "accessibility|aria|screen.?reader" # Search for ClearIndicator implementation ast-grep --pattern 'const ClearIndicator = $_' # Look for aria attributes in Select component fd -e ts -e tsx | xargs rg "aria-|role=" -A 2 -B 2Length of output: 66072
Script:
#!/bin/bash # Search for ClearIndicator implementation and related accessibility code in Select files rg -A 5 -B 5 "ClearIndicator|aria-|role=|onKeyDown|tabIndex" "libs/island-ui/core/src/lib/Select/" # Look for any test files related to Select component fd -e test.tsx -e spec.tsx -e test.ts -e spec.ts . | grep -i selectLength of output: 12388
apps/judicial-system/web/src/components/SelectComponents/SelectComponents.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
apps/judicial-system/web/src/components/SelectComponents/SelectComponents.tsx (3)
24-32: Consider adding ARIA label for better accessibility.The component is well-implemented, but adding an aria-label to the icon would improve accessibility for screen readers.
- <Icon type="filled" icon="chevronDown" color="blue400" /> + <Icon + type="filled" + icon="chevronDown" + color="blue400" + aria-label="Toggle dropdown menu" + />
52-58: Consider adding visual feedback for keyboard navigation.While the component is well-implemented, consider adding visual feedback for keyboard navigation to improve accessibility.
export const Option = (props: OptionProps<ReactSelectOption>) => { return ( <components.Option {...props}> - <Text variant="small">{props.children}</Text> + <Text + variant="small" + color={props.isFocused ? "blue400" : undefined} + > + {props.children} + </Text> </components.Option> ) }
1-58: Consider creating a custom Select component for reusability.These well-implemented select components could be composed into a higher-level custom Select component that encapsulates all these customizations. This would make it easier to maintain consistent select behavior across the application.
Example usage pattern:
// CustomSelect.tsx import { Props } from 'react-select'; import * as SelectComponents from './SelectComponents'; export const CustomSelect = (props: Props<ReactSelectOption>) => ( <Select {...props} components={{ ClearIndicator: SelectComponents.ClearIndicator, DropdownIndicator: SelectComponents.DropdownIndicator, Placeholder: SelectComponents.Placeholder, SingleValue: SelectComponents.SingleValue, Option: SelectComponents.Option, }} /> );
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/judicial-system/web/src/components/CourtDocuments/CourtDocuments.tsx(3 hunks)apps/judicial-system/web/src/components/SelectComponents/SelectComponents.tsx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/judicial-system/web/src/components/CourtDocuments/CourtDocuments.tsx
🧰 Additional context used
📓 Path-based instructions (1)
apps/judicial-system/web/src/components/SelectComponents/SelectComponents.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (4)
apps/judicial-system/web/src/components/SelectComponents/SelectComponents.tsx (4)
1-13: LGTM! Well-organized imports with proper type safety.The imports are logically grouped and include all necessary components and types for implementing custom react-select components.
14-22: LGTM! Well-implemented clear indicator component.The component properly extends react-select's base component while maintaining type safety and following React best practices.
34-42: LGTM! Well-structured placeholder component.The component maintains consistent styling using the Text component while properly extending react-select's base component.
44-50: LGTM! Clean implementation of single value component.The component maintains consistent typography using the Text component while properly extending react-select's base functionality.
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/Processing.tsx (1)
Line range hint
267-280: Add error handling for national registry lookup.The national registry lookup could benefit from better error handling and user feedback.
Consider adding error handling:
useEffect(() => { if (!civilClaimantNationalIdUpdate) { return } const items = personData?.items || [] const person = items[0] setNationalIdNotFound(items.length === 0) + + if (items.length > 1) { + // Handle multiple matches + console.warn('Multiple matches found for national ID') + } const update: UpdateCivilClaimant = { civilClaimantId: civilClaimantNationalIdUpdate.civilClaimantId || '', nationalId: civilClaimantNationalIdUpdate.nationalId, ...(person?.name ? { name: person.name } : {}), } handleSetAndSendCivilClaimantToServer(update) }, [personData])
🧹 Nitpick comments (2)
apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/Processing.tsx (2)
Line range hint
65-77: Consider simplifying the initialize function.Based on the retrieved learning from PR #15421, the
updateCasemethod has its own error handling, making the additional error handling in theinitializefunction unnecessary.Consider simplifying the function:
const initialize = useCallback(async () => { - if (!workingCase.court) { - await updateCase(workingCase.id, { - courtId: user?.institution?.defaultCourtId, - }) - refreshCase() - } + if (!workingCase.court && user?.institution?.defaultCourtId) { + await updateCase(workingCase.id, { courtId: user.institution.defaultCourtId }) + refreshCase() + } }, [ refreshCase, updateCase, user?.institution?.defaultCourtId, workingCase.court, workingCase.id, ])
Line range hint
79-89: Consider optimistic updates for better UX.Based on the learning from PR #17198, consider updating the UI state before making the API call in the
handleNavigationTofunction for a more responsive user experience.Consider this approach:
const handleNavigationTo = useCallback( async (destination: string) => { if (workingCase.state === CaseState.NEW) { + setWorkingCase((prev) => ({ ...prev, state: CaseState.OPEN })) await transitionCase( workingCase.id, CaseTransition.OPEN, setWorkingCase, ) } router.push(`${destination}/${workingCase.id}`) }, [router, setWorkingCase, transitionCase, workingCase], )
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/Processing.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/Processing.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
📓 Learnings (1)
apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/Processing.tsx (3)
Learnt from: gudjong
PR: island-is/island.is#15421
File: apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/Processing.tsx:55-61
Timestamp: 2024-11-12T15:15:11.835Z
Learning: The `updateCase` method in the `apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/Processing.tsx` file has its own error handling, and additional error handling in the `initialize` function is not necessary.
Learnt from: oddsson
PR: island-is/island.is#17192
File: apps/judicial-system/web/src/routes/Prosecutor/Indictments/Indictment/IndictmentCount.tsx:579-587
Timestamp: 2024-12-17T20:28:47.549Z
Learning: In the `IndictmentCount.tsx` file of the `apps/judicial-system/web` project, constraints on the vehicle registration number are planned to be removed. Avoid suggesting changes related to vehicle registration number validation for now.
Learnt from: thorhildurt
PR: island-is/island.is#17198
File: apps/judicial-system/web/src/routes/Prison/IndictmentOverview/IndictmentOverview.tsx:42-50
Timestamp: 2024-12-11T14:25:44.741Z
Learning: In `IndictmentOverview.tsx`, when updating the punishment type, update the UI state before making the API call to immediately reflect the change.
🔇 Additional comments (2)
apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/Processing.tsx (2)
Line range hint
1-44: Well-structured component with proper TypeScript usage!The component follows NextJS best practices with proper type definitions and organized imports.
686-686: LGTM! Proper route handling.The updated
nextUrlcorrectly includes the working case ID, ensuring proper navigation flow.
apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/Processing.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
apps/judicial-system/web/src/components/CourtDocuments/CourtDocuments.tsx (2)
157-204: Consider extracting select styles to a separate file.The current implementation has a large amount of inline styles. Moving these to a dedicated styles file would:
- Improve code maintainability
- Make the component more focused on its logic
- Allow style reuse across other select components
Example structure:
// selectStyles.ts export const getSelectStyles = (theme, isOpen) => ({ control: (baseStyles) => ({...}), menu: (baseStyles) => ({...}), // ... other style objects })
213-218: Improve type safety in the onChange handler.The current implementation uses type casting which could be made safer.
-onChange={(option) => { - handleSubmittedBy( - index, - (option as ReactSelectOption)?.value as UserRole, - ) -}} +onChange={(option: ReactSelectOption | null) => { + if (option?.value) { + handleSubmittedBy(index, option.value as UserRole) + } +}}apps/judicial-system/web/src/components/DefenderInfo/DefenderInfo.tsx (2)
Line range hint
38-67: Simplify conditional logic in title and tooltip renderingThe
getSectionTitleandrenderTooltipfunctions contain nested conditionals that could be simplified for better maintainability.Consider refactoring using lookup objects:
const SECTION_TITLES = { restriction: { prosecution: defenderInfo.restrictionCases.sections.defender.heading, default: defenderInfo.restrictionCases.sections.defender.title, }, investigation: { prosecution: defenderInfo.investigationCases.sections.defender.heading, default: defenderInfo.investigationCases.sections.defender.title, }, } const getSectionTitle = () => { const caseType = isRestrictionCase(workingCase.type) ? 'restriction' : 'investigation' const userRole = isProsecutionUser(user) ? 'prosecution' : 'default' const message = SECTION_TITLES[caseType][userRole] return formatMessage(message, caseType === 'investigation' && userRole === 'default' ? { defenderType: workingCase.sessionArrangements === SessionArrangements.ALL_PRESENT_SPOKESPERSON ? 'Talsmaður' : 'Verjandi', } : undefined ) }Also applies to: 69-91
Line range hint
126-196: Extract defender access radio group into a separate componentThe radio button group for defender access control could be extracted into a reusable component to improve maintainability and reduce duplication.
Consider creating a new component:
interface DefenderAccessRadioGroupProps { caseType: CaseType currentValue: RequestSharedWithDefender onChange: (value: RequestSharedWithDefender) => void disabled: boolean } const DefenderAccessRadioGroup: FC<DefenderAccessRadioGroupProps> = ({ caseType, currentValue, onChange, disabled, }) => { const { formatMessage } = useIntl() const isRestriction = isRestrictionCase(caseType) const options = [ { value: RequestSharedWithDefender.READY_FOR_COURT, labelKey: isRestriction ? defenderInfo.restrictionCases.sections.defenderRequestAccess.labelReadyForCourt : defenderInfo.investigationCases.sections.defenderRequestAccess.labelReadyForCourt, }, // ... other options ] return ( <> {options.map(({ value, labelKey }) => ( <Box key={value} marginTop={2}> <RadioButton name="defender-access" id={`defender-access-${value}`} label={formatMessage(labelKey)} checked={currentValue === value} onChange={() => onChange(value)} large backgroundColor="white" disabled={disabled} /> </Box> ))} </> ) }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
apps/judicial-system/web/src/components/CourtDocuments/CourtDocuments.tsx(3 hunks)apps/judicial-system/web/src/components/DefenderInfo/DefenderInfo.tsx(1 hunks)apps/judicial-system/web/src/components/Table/PastCasesTable/PastCasesTable.tsx(1 hunks)apps/judicial-system/web/src/routes/Court/components/ReceptionAndAssignment/ReceptionAndAssignment.tsx(0 hunks)
💤 Files with no reviewable changes (1)
- apps/judicial-system/web/src/routes/Court/components/ReceptionAndAssignment/ReceptionAndAssignment.tsx
✅ Files skipped from review due to trivial changes (1)
- apps/judicial-system/web/src/components/Table/PastCasesTable/PastCasesTable.tsx
🧰 Additional context used
📓 Path-based instructions (2)
apps/judicial-system/web/src/components/DefenderInfo/DefenderInfo.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/CourtDocuments/CourtDocuments.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (4)
apps/judicial-system/web/src/components/CourtDocuments/CourtDocuments.tsx (1)
19-25: Well-structured component separation!Good job extracting the select-related components into a separate file. This improves code organization and reusability.
apps/judicial-system/web/src/components/DefenderInfo/DefenderInfo.tsx (3)
1-2: Clean import statements approved!The removal of the unused MessageDescriptor import simplifies the code while maintaining full i18n functionality through useIntl.
Line range hint
1-196: Implementation follows NextJS best practicesThe component demonstrates good adherence to NextJS patterns:
- Strong TypeScript usage for type safety
- Efficient state management with React hooks
- Clean component structure and proper separation of concerns
Line range hint
89-96: Verify the usage of force parameter in case updatesThe handleAdvocateChange function always sets
force: truewhen updating the case. Please verify if forcing the update is necessary in all scenarios, as this might bypass important validations.✅ Verification successful
The force parameter usage is appropriate in this context
The force parameter is correctly used to ensure explicit user actions in the UI are properly reflected in the case updates, particularly for critical fields like rulings, custody decisions, and date updates. This is a deliberate design choice backed by test cases and consistent usage patterns across similar components.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for other occurrences of force parameter to understand its usage pattern rg "force:\s*true" -A 5 -B 5Length of output: 65876
apps/judicial-system/web/src/components/CourtDocuments/CourtDocuments.tsx
Show resolved
Hide resolved
… into j-s/merge-outside-fe
Merge case with another that is not in RVG
Asana
What
This PR implements a Input box to update the DB field added in #17507. This is a part in making it possible to merge a case with another case that is not in RVG.
Screenshots / Gifs
Checklist:
Summary by CodeRabbit
Release Notes
New Features
Improvements
User Interface