fix(secondary school): More fixes + stop user if no programs are open for admission + handle if only 1 school or program available

libs/application/template-api-modules/src/lib/modules/templates/secondary-school/secondary-school.service.ts

@@ -49,7 +49,25 @@ export class SecondarySchoolService extends BaseTemplateApiService {
   async getSchools({
     auth,
   }: TemplateApiModuleActionProps): Promise<SecondarySchool[]> {
-    return this.secondarySchoolClient.getSchools(auth)
+    const studentInfo = await this.secondarySchoolClient.getStudentInfo(auth)
+    const schools = await this.secondarySchoolClient.getSchools(auth)
+
+    const schoolIsOpenForAdmission = schools.find((x) =>
+      studentInfo?.isFreshman
+        ? x.isOpenForAdmissionFreshman
+        : x.isOpenForAdmissionFreshman || x.isOpenForAdmissionGeneral,
+    )
+    if (!schoolIsOpenForAdmission) {
+      throw new TemplateApiError(
+        {
+          title: error.errorNoSchoolOpenForAdmissionTitle,
+          summary: error.errorNoSchoolOpenForAdmissionDescription,
+        },
+        400,
+      )
+    }
+
+    return schools
   }
 
   async validateCanCreate({

libs/application/template-api-modules/src/lib/modules/templates/secondary-school/utils.ts

@@ -116,7 +116,7 @@ export const getCleanSchoolSelection = (
 ): ApplicationSelectionSchool[] => {
   const result: ApplicationSelectionSchool[] = []
 
-  let schoolPriority = 0
+  let schoolPriority = 1
 
   const selectionKeys = ['first', 'second', 'third']
   selectionKeys.forEach((selectionKey) => {
@@ -134,11 +134,11 @@ export const getCleanSchoolSelection = (
         schoolId: selectionItem.school.id,
         programs: [
           {
-            priority: 0,
+            priority: 1,
             programId: selectionItem.firstProgram.id,
           },
           {
-            priority: 1,
+            priority: 2,
             programId: selectionItem.secondProgram?.include
               ? selectionItem.secondProgram.id || ''
               : '',

libs/application/templates/secondary-school/src/fields/schoolSelection/SelectionItem.tsx

@@ -11,6 +11,7 @@ import {
   ApplicationType,
   getTranslatedProgram,
   Language,
+  LANGUAGE_CODE_DANISH,
   Program,
   SecondarySchool,
 } from '../../utils'
@@ -34,6 +35,7 @@ export const SelectionItem: FC<FieldBaseProps & SelectionItemProps> = (
   const { application, setFieldLoadingState } = props
   const { setValue, watch } = useFormContext()
   const [isLoadingPrograms, setIsLoadingPrograms] = useState<boolean>(false)
+  const [showSecondProgram, setShowSecondProgram] = useState<boolean>(true)
 
   const isFreshman =
     getValueViaPath<ApplicationType>(
@@ -256,8 +258,10 @@ export const SelectionItem: FC<FieldBaseProps & SelectionItemProps> = (
 
   // default set include=true for second program if freshman
   useEffect(() => {
-    setValue(`${props.field.id}.secondProgram.include`, isFreshman)
-  }, [isFreshman, props.field.id, setValue])
+    const showSecondProgram = isFreshman && programOptions.length !== 1
+    setValue(`${props.field.id}.secondProgram.include`, showSecondProgram)
+    setShowSecondProgram(showSecondProgram)
+  }, [isFreshman, programOptions.length, props.field.id, setValue])
 
   useEffect(() => {
     setFieldLoadingState?.(isLoadingPrograms)
@@ -276,7 +280,13 @@ export const SelectionItem: FC<FieldBaseProps & SelectionItemProps> = (
           backgroundColor="blue"
           required
           options={(schoolOptions || [])
-            .filter((x) => !otherSchoolIds.includes(x.id))
+            .filter(
+              (x) =>
+                (isFreshman
+                  ? x.isOpenForAdmissionFreshman
+                  : x.isOpenForAdmissionGeneral) &&
+                !otherSchoolIds.includes(x.id),
+            )
             .map((school) => {
               return {
                 label: school.name,
@@ -319,7 +329,7 @@ export const SelectionItem: FC<FieldBaseProps & SelectionItemProps> = (
         />
       </Box>
 
-      {isFreshman && (
+      {showSecondProgram && (
         <Box marginTop={2}>
           <Controller
             name={`${props.field.id}.secondProgram.id`}
@@ -397,7 +407,7 @@ export const SelectionItem: FC<FieldBaseProps & SelectionItemProps> = (
                 isDisabled={isLoadingPrograms}
                 value={selectedNordicLanguage}
                 options={nordicLanguageOptions
-                  .filter((x) => x.code !== 'da')
+                  .filter((x) => x.code !== LANGUAGE_CODE_DANISH)
                   .map((language) => {
                     return {
                       label: language.name,