fix(application-system): Fixing duplicate error, removing unused string

[Ballioli]

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• Bug Fixes
  • Updated error message identifier for payment submit failure
  • Corrected default institution label namespace

These changes improve message identification and namespace consistency across the application, ensuring more accurate error and label references.

[coderabbitai]

Walkthrough

This pull request involves modifications to message identifiers in two different TypeScript files within the application's library structure. In libs/application/core/src/lib/messages.ts, the paymentSubmitFailedDescription message's ID was updated from application.system:core.payment.submitTitle to application.system:core.payment.paymentSubmitFailedDescription. Similarly, in libs/portals/my-pages/applications/src/lib/messages.ts, the defaultInstitutionLabel message's ID was changed from application.system:default-institution-label to sp.applications:default-institution-label.

Changes

File	Change Summary
libs/application/core/src/lib/messages.ts	Updated paymentSubmitFailedDescription message ID
libs/portals/my-pages/applications/src/lib/messages.ts	Updated defaultInstitutionLabel message ID and namespace

Possibly related PRs

• fix(social-insurance-maintenance): add warning #17205: Changes to message definitions in messages.ts files
• fix(application-system): Adding/removing contentful messages #17460: Modifications to localization and message management
• fix(application-system): Contentful strings removed #17478: Removal and updates of message definitions

Suggested labels

automerge, deprecated:automerge

Suggested reviewers

• sigruntg
• Toti91

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 63c5a6d and 82e8c68.

📒 Files selected for processing (1)

• libs/portals/my-pages/applications/src/lib/messages.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• libs/portals/my-pages/applications/src/lib/messages.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[datadog-island-is]

Datadog Report

All test runs a511974 🔗

✅ 9 Total Test Services: 0 Failed, 8 Passed
➡️ Test Sessions change in coverage: 14 no change

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
api	0	0	0	4	0	8.56s	1 no change	Link
application-core	0	0	0	97	0	39.82s	1 no change	Link
application-system-api	0	0	0	46	0	2m 55.95s	1 no change	Link
application-template-api-modules	0	0	0	85	0	0s	N/A	Link
application-ui-shell	0	0	0	72	0	0s	N/A	Link
judicial-system-backend	0	0	0	21219	0	13m 25.93s	1 no change	Link
services-auth-delegation-api	0	0	0	270	0	3m 40.8s	1 no change	Link
services-auth-personal-representative	0	0	0	0	0	291.35ms	1 no change	Link
web	0	0	0	84	0	57.31s	1 no change	Link

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

libs/api/domains/driving-license/src/lib/graphql/qualitySignature.resolver.ts (1)

25-25: LGTM! Consistent type usage.

The change maintains consistency with QualityPhotoResolver by using the primitive string type.

Consider extracting common resolver patterns into a shared base class or utility functions, as both QualityPhotoResolver and QualitySignatureResolver share similar structure and authorization logic.

Example base class pattern:

abstract class BaseQualityResolver<T> {
  constructor(protected readonly drivingLicenseService: DrivingLicenseService) {}

  @ResolveField('dataUri', () => String, { nullable: true })
  protected abstract resolveDataUri(
    @Parent() parent: T,
    @CurrentUser() user: User,
  ): Promise<string | null>;
}

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2302406 and 63c5a6d.

📒 Files selected for processing (2)

• libs/api/domains/driving-license/src/lib/graphql/qualityPhoto.resolver.ts (1 hunks)
• libs/api/domains/driving-license/src/lib/graphql/qualitySignature.resolver.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

libs/api/domains/driving-license/src/lib/graphql/qualitySignature.resolver.ts (1)

Pattern libs/**/*: "Confirm that the code adheres to the following:

• Reusability of components and hooks across different NextJS apps.
• TypeScript usage for defining props and exporting types.
• Effective tree-shaking and bundling practices."

libs/api/domains/driving-license/src/lib/graphql/qualityPhoto.resolver.ts (1)

Pattern libs/**/*: "Confirm that the code adheres to the following:

• Reusability of components and hooks across different NextJS apps.
• TypeScript usage for defining props and exporting types.
• Effective tree-shaking and bundling practices."

🔇 Additional comments (1)

libs/api/domains/driving-license/src/lib/graphql/qualityPhoto.resolver.ts (1)

25-25: LGTM! Good TypeScript practice.

The change from Promise<String> to Promise<string> aligns with TypeScript best practices by using primitive types instead of object wrappers.

Let's check for consistency across other resolvers:

✅ Verification successful

Verified: TypeScript primitive type usage is correct and consistent

The change from Promise<String> to Promise<string> in the resolver is an isolated improvement that follows TypeScript best practices. No other resolvers in the codebase use Promise<String>, and GraphQL schema definitions correctly use String type as required by the GraphQL specification.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for other resolvers that might need similar updates
ast-grep --pattern 'Promise<String' 

Length of output: 37

---

Script:

#!/bin/bash
# Search for Promise<String> type annotations in TypeScript files
rg "Promise<String>" --type ts -g "*resolver.ts" -g "*resolvers.ts"

# Search for String type usage in resolver files
rg ":\s*String\b" --type ts -g "*resolver.ts" -g "*resolvers.ts"

# Search for Promise<string> for comparison
rg "Promise<string>" --type ts -g "*resolver.ts" -g "*resolvers.ts"

Length of output: 206

---

Script:

#!/bin/bash
# Search for String type usage in all TypeScript files with context
rg ":\s*(Promise<)?String\b" --type ts -C 2

# Search for string type usage for comparison
rg ":\s*(Promise<)?string\b" --type ts -C 2

# Search in type definitions and schemas
rg "type.*String" --type ts --type graphql -C 2

Length of output: 66186

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.57%. Comparing base (47ba3fc) to head (77d9297).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17615   +/-   ##
=======================================
  Coverage   35.56%   35.57%           
=======================================
  Files        7033     7033           
  Lines      150538   150538           
  Branches    42975    42975           
=======================================
+ Hits        53545    53547    +2     
+ Misses      96993    96991    -2     

Flag	Coverage Δ
air-discount-scheme-backend	48.13% <ø> (ø)
air-discount-scheme-web	0.00% <ø> (ø)
api	3.33% <ø> (ø)
api-domains-air-discount-scheme	37.84% <ø> (ø)
api-domains-assets	26.71% <ø> (ø)
api-domains-auth-admin	48.49% <ø> (ø)
api-domains-communications	39.47% <ø> (ø)
api-domains-criminal-record	47.73% <ø> (ø)
api-domains-driving-license	44.74% <ø> (ø)
api-domains-education	31.03% <ø> (ø)
api-domains-health-insurance	35.09% <ø> (ø)
api-domains-mortgage-certificate	34.91% <ø> (ø)
api-domains-payment-schedule	41.98% <ø> (ø)
application-api-files	61.73% <ø> (ø)
application-core	75.68% <ø> (ø)
application-system-api	38.66% <ø> (ø)
application-template-api-modules	27.55% <ø> (-0.01%)	⬇️
application-templates-accident-notification	27.60% <ø> (ø)
application-templates-car-recycling	3.12% <ø> (ø)
application-templates-criminal-record	25.79% <ø> (ø)
application-templates-driving-license	18.15% <ø> (ø)
application-templates-estate	13.58% <ø> (ø)
application-templates-example-payment	24.66% <ø> (ø)
application-templates-financial-aid	14.99% <ø> (ø)
application-templates-general-petition	23.11% <ø> (ø)
application-templates-inheritance-report	6.59% <ø> (ø)
application-templates-marriage-conditions	14.80% <ø> (ø)
application-templates-mortgage-certificate	43.73% <ø> (ø)
application-templates-new-primary-school	20.62% <ø> (ø)
application-templates-parental-leave	29.92% <ø> (ø)
application-types	6.47% <ø> (ø)
application-ui-components	1.17% <ø> (ø)
application-ui-shell	21.99% <ø> (ø)
clients-charge-fjs-v2	28.88% <ø> (ø)
clients-driving-license	40.60% <ø> (ø)
clients-driving-license-book	43.69% <ø> (ø)
clients-financial-statements-inao	49.41% <ø> (ø)
clients-license-client	1.26% <ø> (ø)
clients-regulations	42.66% <ø> (ø)
clients-rsk-company-registry	31.18% <ø> (ø)
clients-rsk-personal-tax-return	38.32% <ø> (ø)
clients-smartsolutions	12.77% <ø> (ø)
clients-syslumenn	49.14% <ø> (ø)
clients-zendesk	49.64% <ø> (ø)
cms	0.38% <ø> (ø)
cms-translations	38.79% <ø> (ø)
dokobit-signing	61.48% <ø> (ø)
email-service	59.51% <ø> (ø)
feature-flags	90.24% <ø> (ø)
file-storage	45.10% <ø> (ø)
financial-aid-backend	51.35% <ø> (ø)
judicial-system-api	20.07% <ø> (ø)
judicial-system-audit-trail	68.36% <ø> (ø)
judicial-system-backend	55.79% <ø> (ø)
judicial-system-message	66.16% <ø> (ø)
judicial-system-message-handler	47.72% <ø> (ø)
judicial-system-scheduler	71.20% <ø> (ø)
judicial-system-web	27.97% <ø> (ø)
license-api	42.91% <ø> (+0.05%)	⬆️
nest-config	75.92% <ø> (ø)
nest-feature-flags	49.93% <ø> (-0.64%)	⬇️
nova-sms	60.77% <ø> (ø)
portals-admin-regulations-admin	1.80% <ø> (ø)
portals-core	19.60% <ø> (ø)
services-auth-admin-api	52.51% <ø> (ø)
services-auth-delegation-api	58.43% <ø> (-0.09%)	⬇️
services-auth-ids-api	52.48% <ø> (-0.01%)	⬇️
services-auth-public-api	49.35% <ø> (ø)
services-sessions	65.27% <ø> (ø)
services-university-gateway	49.45% <ø> (-0.09%)	⬇️
services-user-notification	46.51% <ø> (ø)
services-user-profile	56.91% <ø> (ø)
web	2.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
libs/application/core/src/lib/messages.ts	100.00% <ø> (ø)

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ba3fc...77d9297. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs f337e91 🔗

✅ 10 Total Test Services: 0 Failed, 10 Passed
🔻 Test Sessions change in coverage: 2 decreased, 198 no change

Test Services

This report shows up to 10 services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
air-discount-scheme-backend	0	0	0	63	0	25.78s	1 no change	Link
air-discount-scheme-web	0	0	0	2	0	7.51s	1 no change	Link
api	0	0	0	4	0	2.76s	1 no change	Link
api-domains-air-discount-scheme	0	0	0	6	0	17.98s	1 no change	Link
api-domains-assets	0	0	0	3	0	10.34s	1 no change	Link
api-domains-auth-admin	0	0	0	18	0	9.56s	1 no change	Link
api-domains-communications	0	0	0	5	0	29.97s	1 no change	Link
api-domains-criminal-record	0	0	0	5	0	7.97s	1 no change	Link
api-domains-driving-license	0	0	0	23	0	30.88s	1 no change	Link
api-domains-education	0	0	0	8	0	18.93s	1 no change	Link

🔻 Code Coverage Decreases vs Default Branch (2)

• nest-feature-flags - jest 55.77% (-0.46%) - Details
• services-university-gateway - jest 45.23% (-0.02%) - Details