fix(secondary school): Update message IDs #17628
Conversation
WalkthroughThis pull request focuses on refining message identifiers across multiple files in the secondary school application templates. The changes involve updating specific message IDs to more accurately reflect their intended purpose and state. Modifications are made in three files: Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
libs/application/templates/secondary-school/src/lib/messages/application.ts (1)
33-36: Fix the description comment to match the "in review" state.The description comment incorrectly states "when application is completed" but this message is for the "in review" state.
id: 'ss.application:actionCardInReview', defaultMessage: 'Í vinnslu hjá stofnun', description: - 'Description of application state/status when application is completed', + 'Description of application state/status when application is in review',
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
libs/application/templates/secondary-school/src/lib/messages/application.ts(1 hunks)libs/application/templates/secondary-school/src/lib/messages/conclusion.ts(1 hunks)libs/application/templates/secondary-school/src/lib/messages/error.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
libs/application/templates/secondary-school/src/lib/messages/error.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/secondary-school/src/lib/messages/application.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/secondary-school/src/lib/messages/conclusion.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
🔇 Additional comments (3)
libs/application/templates/secondary-school/src/lib/messages/error.ts (1)
15-15: LGTM! Message ID correctly updated to match its purpose.The ID change from 'errorValidateCanCreateTitle' to 'errorValidateCanCreateDescription' properly aligns with the message's purpose as a description rather than a title.
libs/application/templates/secondary-school/src/lib/messages/application.ts (1)
33-33: LGTM! Message ID correctly updated to match the application state.The ID change from 'actionCardCompleted' to 'actionCardInReview' properly reflects the "in review" state of the application.
libs/application/templates/secondary-school/src/lib/messages/conclusion.ts (1)
68-68: LGTM! Message IDs correctly differentiated for freshman and general cases.The ID changes properly distinguish between freshman and general alert messages, making the code more maintainable and the message purposes clearer.
Also applies to: 74-74
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17628 +/- ##
==========================================
- Coverage 35.56% 35.51% -0.06%
==========================================
Files 7033 7033
Lines 150539 150736 +197
Branches 42976 43051 +75
==========================================
- Hits 53545 53537 -8
- Misses 96994 97199 +205
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 8 Total Test Services: 0 Failed, 7 Passed Test Services
🔻 Code Coverage Decreases vs Default Branch (1)
|
Datadog ReportAll test runs ✅ 4 Total Test Services: 0 Failed, 4 Passed Test Services
🔻 Code Coverage Decreases vs Default Branch (1)
|
…g fail. Formatting still sightly off
...
Attach a link to issue if relevant
What
Specify what you're trying to achieve
Why
Specify why you need to achieve this
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist:
Summary by CodeRabbit
actionCardInReviewmessage ID to accurately reflect application review status