fix(application-system): Fix typing for updateOnSelect

[norda-gunni]

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

Release Notes

• Improvements

  • Simplified asynchronous select field configuration by changing updateOnSelect from array to single value.
  • Updated type definitions for async select fields to accommodate both single strings and arrays.
  • Streamlined state management for async select form fields.

• Technical Updates

  • Refined handling of selected values in async select components.
  • Improved logic for tracking and updating selected values.

[coderabbitai]

Walkthrough

This pull request modifies the handling of the updateOnSelect property across multiple files, changing it from an array format to a single string format. This adjustment affects type definitions, form configurations, and UI components, streamlining how selected values are tracked and updated in asynchronous select fields.

Changes

File	Change Summary
libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/newSchoolSubSection.ts	Changed updateOnSelect from ['newSchool.municipality'] to 'newSchool.municipality'
libs/application/templates/reference-template/src/forms/exampleForm/simpleInputsSection/asyncSelectSubsection.ts	Modified updateOnSelect from ['primaryAsyncSelect'] to 'primaryAsyncSelect' and expanded description in asyncSelectDescription
libs/application/types/src/lib/Fields.ts	Updated type definitions: - selectedValue from string[] to `string
libs/application/ui-fields/src/lib/AsyncSelectFormField/AsyncSelectFormField.tsx	Refactored state management and effect handling to work with string-based updateOnSelect

Possibly related PRs

• feat(new-primary-school): Reason page - Data implementation #16304: The changes in this PR involve modifications to the updateOnSelect property in the asyncSelectSubsection, which is similar to the changes made in the main PR regarding the updateOnSelect property in the newSchoolSubSection.
• feat(application-system): Add dependent loading to async select #17525: This PR introduces the updateOnSelect property to the buildAsyncSelectField function, which aligns with the changes made in the main PR where the updateOnSelect property is added to the async select fields in the newSchoolSubSection.
• feat(new-primary-school): Update new school page to use updateOnSelect #17612: This PR modifies the newSchoolSubSection to include the updateOnSelect property in the loadOptions function, directly relating to the changes made in the main PR regarding the handling of the updateOnSelect property.

Suggested labels

automerge

Suggested reviewers

• Toti91
• jonnigs
• kksteini

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eb3283f and 41b95fa.

📒 Files selected for processing (3)

• libs/application/templates/reference-template/src/forms/exampleForm/simpleInputsSection/asyncSelectSubsection.ts (2 hunks)
• libs/application/types/src/lib/Fields.ts (2 hunks)
• libs/application/ui-fields/src/lib/AsyncSelectFormField/AsyncSelectFormField.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

• libs/application/types/src/lib/Fields.ts
• libs/application/templates/reference-template/src/forms/exampleForm/simpleInputsSection/asyncSelectSubsection.ts
• libs/application/ui-fields/src/lib/AsyncSelectFormField/AsyncSelectFormField.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[helgifr]

lgtm 👍