-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Update winston and winston-transport to resolve memory leak #7134
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7134 +/- ##
==========================================
- Coverage 27.22% 26.91% -0.31%
==========================================
Files 3139 3183 +44
Lines 53163 53848 +685
Branches 13124 13343 +219
==========================================
+ Hits 14475 14495 +20
- Misses 38688 39353 +665
Flags with carried forward coverage won't be shown. Click here to find out more. |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
What
Update winston and winston-transport to version that include the following fix for memory leaks in those libraries.
winstonjs/winston#2057
winstonjs/winston-transport#81
Why
These memory leaks were affecting memory consumption in our NestJS servers.
Screenshots / Gifs
Memory consumption for 100 req/s over 10 minutes.
Before:
After:
Checklist: