Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Update winston and winston-transport to resolve memory leak #7134

Merged
merged 1 commit into from
Apr 9, 2022

Conversation

saevarma
Copy link
Member

@saevarma saevarma commented Apr 8, 2022

What

Update winston and winston-transport to version that include the following fix for memory leaks in those libraries.

winstonjs/winston#2057
winstonjs/winston-transport#81

Why

These memory leaks were affecting memory consumption in our NestJS servers.

Screenshots / Gifs

Memory consumption for 100 req/s over 10 minutes.
Before:
image

After:
image

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

@saevarma saevarma requested a review from a team as a code owner April 8, 2022 22:37
@saevarma saevarma requested a review from eirikurn April 8, 2022 22:37
@saevarma saevarma added the automerge Merge this PR as soon as all checks pass label Apr 8, 2022
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #7134 (889a010) into main (b339f94) will decrease coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7134      +/-   ##
==========================================
- Coverage   27.22%   26.91%   -0.31%     
==========================================
  Files        3139     3183      +44     
  Lines       53163    53848     +685     
  Branches    13124    13343     +219     
==========================================
+ Hits        14475    14495      +20     
- Misses      38688    39353     +665     
Flag Coverage Δ
air-discount-scheme-backend 73.50% <ø> (ø)
api 6.38% <ø> (ø)
api-catalogue-services 82.55% <ø> (ø)
api-domains-criminal-record 48.71% <ø> (ø)
api-domains-driving-license 47.84% <ø> (ø)
api-domains-education 18.80% <ø> (ø)
api-domains-license-service 9.29% <ø> (ø)
api-domains-mortgage-certificate 35.84% <ø> (ø)
api-domains-payment-schedule 49.60% <ø> (ø)
application-system-api 69.60% <ø> (ø)
application-templates-accident-notification 22.37% <ø> (ø)
application-templates-criminal-record 2.27% <ø> (ø)
application-templates-driving-license 6.98% <ø> (ø)
application-templates-example-payment 10.41% <ø> (ø)
application-templates-general-petition 3.53% <ø> (ø)
application-templates-health-insurance 27.86% <ø> (ø)
application-templates-mortgage-certificate 7.57% <ø> (ø)
application-templates-parental-leave 21.39% <ø> (ø)
application-ui-shell 55.03% <ø> (ø)
auth-nest-tools 10.89% <ø> (ø)
auth-react 66.54% <ø> (ø)
clients-driving-license 7.75% <ø> (ø)
clients-payment-schedule 2.46% <ø> (ø)
clients-syslumenn 75.87% <ø> (ø)
content-search-index-manager 95.65% <ø> (ø)
contentful-translation-extension 53.70% <ø> (ø)
dokobit-signing 76.05% <ø> (ø)
download-service 63.10% <ø> (ø)
email-service 65.30% <ø> (ø)
feature-flags 55.76% <ø> (ø)
file-storage 23.07% <ø> (ø)
financial-aid-backend 50.87% <ø> (ø)
gjafakort-web 0.00% <ø> (ø)
health-insurance 36.16% <ø> (ø)
infra-tracing 47.82% <ø> (ø)
island-ui-core 26.70% <ø> (ø)
judicial-system-api 1.32% <ø> (ø)
judicial-system-audit-trail 87.05% <ø> (ø)
judicial-system-backend 42.42% <ø> (ø)
judicial-system-formatters 63.80% <ø> (ø)
judicial-system-scheduler 65.11% <ø> (ø)
judicial-system-types 60.27% <ø> (ø)
judicial-system-web 25.24% <ø> (ø)
localization 10.03% <ø> (ø)
logging 27.41% <ø> (ø)
message-queue 70.74% <ø> (ø)
nest-audit 90.90% <ø> (ø)
nest-config 95.97% <ø> (ø)
nest-feature-flags 89.13% <ø> (ø)
nest-problem 87.68% <ø> (ø)
nest-sequelize 94.44% <ø> (ø)
nest-swagger 93.18% <ø> (ø)
nova-sms 75.00% <ø> (ø)
reference-backend 73.86% <ø> (ø)
residence-history 85.00% <ø> (ø)
service-portal-health 16.00% <ø> (ø)
services-documents 61.42% <ø> (ø)
services-endorsements-api 78.48% <ø> (ø)
services-user-notification 44.91% <ø> (ø)
shared-babel 73.48% <ø> (ø)
shared-form-fields 26.66% <ø> (ø)
shared-mocking 65.21% <ø> (ø)
shared-pii 90.90% <ø> (ø)
shared-problem 85.00% <ø> (ø)
shared-utils 69.64% <ø> (ø)
skilavottord-ws 23.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@cypress
Copy link

cypress bot commented Apr 8, 2022



Test summary

147 0 7 0Flakiness 0


Run details

Project island.is
Status Passed
Commit 565d585 ℹ️
Started Apr 8, 2022 10:54 PM
Ended Apr 8, 2022 11:13 PM
Duration 19:40 💡
OS Linux Ubuntu - 20.04
Browser Electron 91

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@eirikurn eirikurn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@kodiakhq kodiakhq bot merged commit 5df8209 into main Apr 9, 2022
@kodiakhq kodiakhq bot deleted the core/update-winston branch April 9, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants