This repository has been archived by the owner on Oct 10, 2021. It is now read-only.
make is easy to configure this via inventory #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whikloj
reviewed
Jul 12, 2019
defaults/main.yml
Outdated
| @@ -33,13 +39,13 @@ alpaca_settings: | |||
| settings: | |||
| input.stream: activemq:topic:fedora | |||
| triplestore.reindex.stream: activemq:queue:triplestore.reindex | |||
| triplestore.baseUrl: http://localhost:8080/bigdata/namespace/islandora/sparql | |||
| triplestore.baseUrl: "{{ alpaca_triplestore_base_url }}/namespace/islandora/sparql" | |||
There was a problem hiding this comment.
If we are going part way, why not remove the assumption that all triplestores will use the "islandora" namespace.
defaults/main.yml
Outdated
| alpaca_milliner_base_url: http://localhost:8000/milliner/ | ||
| alpaca_gemini_base_url: http://localhost:8000/gemini/ | ||
| alpaca_houdini_base_url: http://localhost:8000/houdini/convert | ||
| alpaca_homarus_base_url: http://localhost:8000/homarus/convert |
There was a problem hiding this comment.
Feels like the name ..._base_url might be incorrect for these last two.
There was a problem hiding this comment.
@whikloj endpoint?
| @@ -25,6 +25,12 @@ alpaca_karaf_deploy_dir: "{{ alpaca_karaf_dir }}/deploy" | |||
| alpaca_karaf_user: karaf | |||
| alpaca_local_mvn_path: /opt/maven/repo | |||
|
|
|||
| alpaca_triplestore_base_url: http://localhost:8080/bigdata | |||
There was a problem hiding this comment.
Probably should be consistent on whether to end with a slash or not. Unless we can adjust to account for either
|
Addressed your feedback. Triplestore url is used here as well: https://github.com/Islandora-Devops/ansible-role-blazegraph. Will update that role as well. |
|
|
dannylamb
approved these changes
Jul 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Make the urls as variable so they can be configured more easily in the inventory.
How should this be tested?
Interested parties
@Islandora-Devops/committers