Skip to content
This repository has been archived by the owner on Oct 10, 2021. It is now read-only.

Remove redundant Drupal module download. #7

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

alxp
Copy link
Contributor

@alxp alxp commented Oct 21, 2020

GitHub Issue: (link)

Islandora/documentation#1638

  • Other Relevant Links (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

What does this Pull Request do?

Removes invocations of composer and drush attempting to install the islandora_fits Drupal module from the Ansible role. This composer invocation is causing an out-of-memory error when I attempt a Vagrant provision.

The module is downloaded and installed in the webserver/drupal.yml inventory tasks already so this is also redundant. See: https://github.com/Islandora-Devops/islandora-playbook/blob/dev/inventory/vagrant/group_vars/webserver/drupal.yml#L23

What's new?

  • Ansible commands that invoke composer and drush are removed.

How should this be tested?

  • Run an ansible build and observe that the composer stop that was causing the out-of-memory error no longer runs and Ansible is able to continue past the role.

Additional Notes:

I intend to also make a request to point the playbook requirements.yml at the '8.x-1.x' branch of islandora_fits, and then subsequently to get it moved to the islandora Github repo but for now this change fixes the Vagrant crash.

Interested parties

@ajstanley @Islandora-Devops/committers

@elizoller elizoller self-assigned this Oct 21, 2020
Copy link
Contributor

@ajstanley ajstanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally works.

@elizoller elizoller removed their assignment Oct 21, 2020
@elizoller elizoller merged commit c46dc2d into islandora-deprecated:main Oct 22, 2020
@rosiel rosiel deleted the composer-cleanup branch September 10, 2021 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants