This repository has been archived by the owner on Oct 10, 2021. It is now read-only.
Add: PR template, LICENSE, CONTRIUBTING.md #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoa! I think your PR template is a copy of the Contributing.md. |
|
@rosiel so it was. Copypasta error. Hopefully that will be my one mistake for the batch 😄 |
rosiel
approved these changes
Jul 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#1173 and Islandora/documentation#1188 and Islandora/documentation#1202
What does this Pull Request do?
How should this be tested?
Additional notes
I know it's a convention, but titling all of these in ALL CAPS makes me feel like I am yelling at future contributors. But not to get off my lawn, because these files are to invite people to our lawn.
Interested parties
@Islandora-Devops/committers