Update keyboard plugin #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yboard is the successor and should be a drop-in replacement
… no longer supported
|
@kbullaughey This issue goes lists out some differences in the upgrade ionic-team/ionic-plugin-keyboard#305 (comment) |
|
Thanks! This slipped through but I'll get it in next week. |
|
Hi, we're waiting on these changes to use the new plugin in our project. When is the approximate time when this change will be merged in? |
|
All I can do is say sorry this got dropped! All on me, thank you for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to the new
cordova-plugin-ionic-keyboardplugin turned out to be more involved than I expected. There are two main differences I noticed:Keyboardplugin moved fromwindow.cordova.plugins.Keyboardtowindow.Keyboard. We now check both places.native.keyboardshowtokeyboardDidShow. And there are new events, i.e., DidShow and WillShow varieties.A problem with this PR at the moment is that the event name changes are not backwards compatible and there's not a one-step upgrade path. You would need to remember to remove the old cordova plugin and add the new one. I fixed the blueprint so that for new projects it installs the correct one, but I'm not sure what the appropriate behavior is for upgrades. Is there a graceful way to handle this?