Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue warning for invalid height prop | v0.7.1 #424

Closed
aovcina opened this issue Nov 19, 2024 · 0 comments · Fixed by #425
Closed

Vue warning for invalid height prop | v0.7.1 #424

aovcina opened this issue Nov 19, 2024 · 0 comments · Fixed by #425

Comments

@aovcina
Copy link
Contributor

aovcina commented Nov 19, 2024

Describe the bug
Version 0.7.1 introduced the height prop, which causes a Vue warning due to an invalid prop type. The height prop is expected to have a type of Number, but its default value is set to 'auto' (a string).

To Reproduce
Steps to reproduce the behavior:

  1. Install vue3-carousel version 0.7.1.
  2. Use the vue3-carousel component without explicitly setting the height prop.
  3. Check the browser console for Vue warnings about invalid prop types.

Expected behavior
Lib. shouldn't cause any issues with default setup.

Screenshots

[Vue warn]: Invalid prop: type check failed for prop "height". Expected Number with value NaN, got String with value "auto". 
  at <Carousel ref="carousel" class="carousel" autoplay=7000  ... > 

Desktop (please complete the following information):

  • OS: Ubuntu 22.04
  • Browser: Chrome
  • Version: 131.0.6778.69 (Official Build) (64-bit)

Smartphone (please complete the following information):

  • Device: N/A
  • OS: N/A
  • Browser: N/A
  • Version: N/A

Additional context

height: 'auto',

aovcina added a commit to aovcina/vue3-carousel that referenced this issue Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant