feat: add paginated navigation for carousel pagination #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofandel
force-pushed
the
feat/paginated-pagination
branch
3 times, most recently
from
cb0e462 to
df3c1a5
Compare
ismail9k
reviewed
Dec 11, 2024
Tofandel
force-pushed
the
feat/paginated-pagination
branch
from
df3c1a5 to
3315633
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #301
Adds a prop
paginatedto the carousel pagination, that will change the pagination to be based on the number of pages (via itemsToShow) rather than the number of slidesSo if you have 10 slides and 4 items to show, you have 3 pages and 3 clickable buttons instead of 10
The paginated prop has no effect if itemsToShow is 1