Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type attribute for siren actions #36

Merged
merged 1 commit into from
Apr 29, 2014
Merged

Add type attribute for siren actions #36

merged 1 commit into from
Apr 29, 2014

Conversation

erezesk
Copy link
Contributor

@erezesk erezesk commented Apr 29, 2014

This is a very small PR which allows adding the type attribute to actions in the Siren adapter.
As seen in the Siren docs

@ismasan
Copy link
Owner

ismasan commented Apr 29, 2014

Great, thanks! Could you ask a test case for it?

@erezesk
Copy link
Contributor Author

erezesk commented Apr 29, 2014

Added spec to check type exists in the hash

ismasan pushed a commit that referenced this pull request Apr 29, 2014
Add type attribute for siren actions
@ismasan ismasan merged commit 2c2c06f into ismasan:master Apr 29, 2014
@erezesk erezesk deleted the add-type-to-siren-actions branch April 29, 2014 18:48
@erezesk erezesk restored the add-type-to-siren-actions branch April 29, 2014 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants