Fixes to be more compatible with Translatable module's javascript #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he modeladmin template, so that translatables javascript will still work as it should. Also changed an array to old syntax so that it works with php 5.3
| @@ -9,9 +9,9 @@ class TranslatableCatalogExtension extends Extension | |||
| /** | |||
| * @var array | |||
| */ | |||
| private static $allowed_actions = [ | |||
| private static $allowed_actions = array( | |||
There was a problem hiding this comment.
Does this need to be here when we are now using LangForm instead?
|
@sanderha thanks for this! Just one question :) |
|
Ah it seem no longer to be required indeed. Would you mind removing it or should I do a PR? |
|
@sanderha if you make the change on your local branch then push it up, it will update this PR. Can you do that? |
|
There we go :) |
stevie-mayhew
added a commit
that referenced
this pull request
Feb 23, 2016
Fixes to be more compatible with Translatable module's javascript
|
Awesome, thank you @sanderha ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change name of language form to "LangForm" and added a CSS class to the modeladmin template, so that translatables javascript will still work as it should. Also changed an array to old syntax so that it works with php 5.3