Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use portable header identifiers #2149

Merged
merged 10 commits into from
Oct 12, 2023

Conversation

apenn-msft
Copy link
Contributor

@apenn-msft apenn-msft commented Oct 10, 2023

add a new rule governing how to compose portable header path identifiers such that they respect proper casing (<vector>, not <VECTOR>) and portable path separators ('/' and not '\')

add a new rule governing how to compose portable header path identifiers such that they respect proper casing (<vector>, not <VECTOR>) and portable path separators ('/')
@apenn-msft
Copy link
Contributor Author

apenn-msft commented Oct 11, 2023

can someone help me fix the spelling warning? as far as I can tell it's complaining about the word "utils" appearing in code sample where "utils" already appears and possibly the only complaint is it appears in the comment of the code, which seems just way over done.

@cubbimew
Copy link
Member

can someone help me fix the spelling warning? as far as I can tell it's complaining about the word "utils" appearing in code sample where "utils" already appears

yes, it wants you to add 'utils' next to util to ./scripts/hunspell/isocpp.dic

@apenn-msft
Copy link
Contributor Author

can someone help me fix the spelling warning? as far as I can tell it's complaining about the word "utils" appearing in code sample where "utils" already appears

yes, it wants you to add 'utils' next to util to ./scripts/hunspell/isocpp.dic

thanks, I guess if that's an indication util is the more normalized thing for "utilities" I'll probably just rename the example to use util

@apenn-msft
Copy link
Contributor Author

I did some searching on the webs, I think practically people name these things "utils" but standard has:
https://en.cppreference.com/w/cpp/header/utility

so util it is

@hsutter
Copy link
Contributor

hsutter commented Oct 12, 2023

Editors call: Looks good, thanks!

@hsutter hsutter merged commit 2a3690d into isocpp:master Oct 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants