Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for depsLockFilePath #19

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Fix for depsLockFilePath #19

merged 1 commit into from
Jan 17, 2022

Conversation

plumdog
Copy link
Contributor

@plumdog plumdog commented Jan 17, 2022

I think this is a fix akin to aws/aws-cdk#12115 (comment).

I had been hitting errors like:

Error: Expected depsLockFilePath: /home/me/myproject/package-lock.json to be under projectRoot: /home/me/myproject/node_modules/ses-smtp-credentials-cdk/provider (../../../package-lock.json)

That is, it is hunting for the package-lock up the tree and finding it in my main project, not the one in ./provider for this dependency.

@plumdog plumdog merged commit fddc314 into master Jan 17, 2022
@plumdog plumdog deleted the fix-for-depslockfilepath branch January 17, 2022 15:27
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant