Use first limit as default in ProductFilter
#2540
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have multiple product or category filters on the page and one of the product filters has
iso_enableLimit
enabled then filtering might not work in general.What happens is that you are first redirected to e.g.
products?isorc=20
and then back to e.g.products?isorc=1
, completely ignoring the filter configuration of the request cache ID 20. This can happen if the config ID 20 does not contain alimit
from the product filter module that hasiso_enableLimit
enabled.The
ProductFilter
module then thinks the config is wrong and executes:core/system/modules/isotope/library/Isotope/Module/ProductFilter.php
Lines 466 to 474 in a23ea30
This then enables
$this->blnUpdateCache = true;
and thus the filter will redirect to another request cache URL.This PR fixes that by using the first limit value as the default when fetching
getFirstLimitForModules()
from the request cache.