Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ipsc stdlib was missing some builtins for the wasm32 target which caused the following issue: #2248
Running tests on windows was also not well supported (I don't think it ever worked ?) so I fixed it. (note I ran the x86 tests to check if everything was still working fine).
I bumped emscripten version to 3.1.31 (we could perhaps even bump to
3.1.32or3.1.33?).The objective was to use a more recent version of emscripten to make sure we have as few issues as possible related to WebAssembly/simd#209 (as mentionned in this old PR #1750 ).
Tests results:
According to #1750 the clock test failing is expected.
However I'm not sure about the atomics. From what I saw this seems to be pretty generic code in
builtins\util.m4, so maybe bad codegen from llvm if the version we are using predates the final renumbering of opcodes ? Those date back to 2020 though so I would expect LLVM13 to have the correct opcodes.If @aschrein has any insight on what could be the issue it would be very helpful !