Skip to content

Browser manager refactor #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MatthewZMSU wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Browser manager refactor #42

MatthewZMSU wants to merge 21 commits into from

Conversation

@MatthewZMSU
Copy link
Contributor

@MatthewZMSU MatthewZMSU commented Dec 20, 2024 •
edited
Loading

Description

Refactored browser managers so they now do not use syncer and bs4. They do not skip middlewares after PuppeteerServiceDownloaderMiddleware. They do not log useless messages to the console.
Temporiraly dropped Pyppeteer support since it is not actively maintained bu the community.
Slightly changed CI.
Added playwright test spider.
Added documentation

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested it locally with several scrapy spiders.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

MatthewZMSU
MatthewZMSU commented Dec 20, 2024
View reviewed changes
.github/workflows/python-test.yml
include:
- python-version: "3.7.x" # Min Python version (No 3.6 version in GitHub repository)
- python-version: "3.8.x"
- python-version: "3.8.x" # Min Python version (No 3.7 version in GitHub repository)
Copy link
Contributor Author

@MatthewZMSU MatthewZMSU Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub dropped Python3.7 support

@MatthewZMSU MatthewZMSU requested a review from mxsnq December 20, 2024 11:33
@MatthewZMSU MatthewZMSU self-assigned this Dec 20, 2024
@MatthewZMSU MatthewZMSU added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxsnq mxsnq Awaiting requested review from mxsnq

At least 1 approving review is required to merge this pull request.

Assignees

@MatthewZMSU MatthewZMSU

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MatthewZMSU