Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walking one step at a time #24

Closed
wants to merge 9 commits into from
Closed

Conversation

tabinohito
Copy link

This PR allows the step at a time walking mode as follows:
output

@mmurooka
Copy link
Member

Thanks for adding new features and sharing a nice video 👍

However, for the following reasons, I think it is better for now that this patch is used in your branch, not merged into the main branch.

  • I don't know how common the step-by-step functionality is requested. To avoid over-complicating the BWC code, I think that a separate branch of BWC or a separate controller that inherits from BWC is sufficient for less common functionalities.
  • Even if step-by-step functionality were to be added, I think a simpler implementation would be possible. Without making any changes to the FootManager, it would be better to simply call appendFootstep in the GUI callback of the dedicated state. (Note that in velocity mode, on the other hand, this approach is not possible because the target foot position must be changed each cycle.)

So, let's close this PR for a while and review the implementation when it becomes clear that this feature is generally required. Thanks again for your contribution!

@mmurooka mmurooka closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants