utils: html: Normalize misaka extensions #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ix5
commented
Jan 17, 2021
ix5
force-pushed
the
extensions-normalize
branch
2 times, most recently
from
55b14ed to
c64c630
Compare
ix5
changed the title
make coverage
nosetests --with-doctest --with-coverage --cover-package=isso --cover-html isso/
................................................................................
Name Stmts Miss Cover
-----------------------------------------------
isso/__init__.py 164 70 57%
isso/config.py 77 11 86%
isso/core.py 68 20 71%
isso/db/__init__.py 66 6 91%
isso/db/comments.py 135 20 85%
isso/db/preferences.py 17 0 100%
isso/db/spam.py 36 0 100%
isso/db/threads.py 15 1 93%
isso/dispatch.py 39 23 41%
isso/ext/__init__.py 10 0 100%
isso/ext/notifications.py 150 100 33%
isso/migrate.py 201 27 87%
isso/run.py 5 0 100%
isso/utils/__init__.py 75 16 79%
isso/utils/hash.py 67 8 88%
isso/utils/html.py 51 1 98%
isso/utils/http.py 39 25 36%
isso/utils/parse.py 43 2 95%
isso/views/__init__.py 36 8 78%
isso/views/comments.py 460 129 72%
isso/wsgi.py 103 26 75%
-----------------------------------------------
TOTAL 1857 493 73%
----------------------------------------------------------------------
Ran 80 tests in 9.088s
OK |
ix5
force-pushed
the
extensions-normalize
branch
from
97eb7fe to
33dec87
Compare
|
Rebased and re-tested on Python 3.10 |
As of version 0.12.2, Isso uses misaka 2.0 to render markdown. Misaka 2.0 uses `dashed-case` instead of `snake_case` for options. Normalize passed extensions to dashed-case to avoid mistakes. Note: Flags have only been around in Isso with misaka 2.0, so I hope users did not use dashed case with them.
ix5
force-pushed
the
extensions-normalize
branch
from
33dec87 to
ffcdfcf
Compare
jelmer
approved these changes
Jan 4, 2022
ix5
added a commit
to ix5/isso
that referenced
this pull request
Jan 5, 2022
As of version 0.12.2, Isso uses misaka 2.0 to render markdown. Misaka 2.0 uses `dashed-case` instead of `snake_case` for options. Normalize passed extensions to dashed-case to avoid mistakes. Note: Flags have only been around in Isso with misaka 2.0, so I hope users did not use dashed case with them.
|
@jelmer do you have a preference for merge style? I tried doing your style which I think consists of cherry-picking and manually editing the title to add the PR number, see https://github.com/ix5/isso/tree/extensions-normalize-686 |
|
I generally just use Squash and merge in the GitHub UI unless there's a good reason to keep the individual commits around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of version 0.12.2, Isso uses misaka 2.0 to render markdown. Misaka 2.0 uses
dashed-caseinstead ofsnake_casefor options.Normalize passed extensions to dashed-case to avoid mistakes.
Note: Flags have only been around in Isso with misaka 2.0, so I hope users did not use dashed case with them.