[server] isso/init: Log paths at start, error if not found; ISSO_SETTINGS takes precedence over -c flag #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ix5
added
server
|
Tested with: Plain isso$ isso -c share/isso-dev.cfg run
2022-05-01 15:54:55,248 INFO: Using configuration file '/home/user/isso/isso/share/isso-dev.cfg'
2022-05-01 15:54:55,260 INFO: Using database at '/home/user/isso/isso/comments.db'-> works $ ISSO_SETTINGS=share/isso-dev.cfg isso run
2022-05-05 23:13:08,039 INFO: Using configuration file '/home/user/isso/share/isso-dev.cfg'
2022-05-05 23:13:08,051 INFO: Using database at '/home/user/isso/comments.db'
-> Now works, since gunicorn$ ISSO_SETTINGS=share/isso-dev.cfg gunicorn -b 0.0.0.0:8080 isso.run
[2022-05-01 15:53:38 +0200] [24971] [INFO] Starting gunicorn 20.1.0
[2022-05-01 15:53:38 +0200] [24971] [INFO] Listening at: http://0.0.0.0:8080 (24971)
[2022-05-01 15:53:38 +0200] [24971] [INFO] Using worker: sync
[2022-05-01 15:53:38 +0200] [24972] [INFO] Booting worker with pid: 24972
2022-05-01 15:53:38,834 INFO: Using database at '/home/user/isso/isso/comments.db'-> works (Note: Multiple sites$ ISSO_SETTINGS=share/isso-dev.cfg gunicorn -b 0.0.0.0:8080 isso.dispatch
[2022-05-01 15:55:29 +0200] [25135] [INFO] Starting gunicorn 20.1.0
[2022-05-01 15:55:29 +0200] [25135] [INFO] Listening at: http://0.0.0.0:8080 (25135)
[2022-05-01 15:55:29 +0200] [25135] [INFO] Using worker: sync
[2022-05-01 15:55:29 +0200] [25136] [INFO] Booting worker with pid: 25136
2022-05-01 15:55:29,887 INFO: Using database at '/home/user/isso/isso/comments.db'with |
ix5
force-pushed
the
startup-logging
branch
2 times, most recently
from
ce97332 to
6680858
Compare
This restores the behavior as was documented in the server config docs, i.e. makes it possible to use `ISSO_SETTINGS=share/isso-dev.cfg isso run`. This used to fail as `ISSO_SETTINGS` was only read by WSGI invocations of `isso.dispatch` or `isso.run`
ix5
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isso/init: Log paths at start, error if not found
Fixes #585
isso/init: ISSO_SETTINGS takes precedence over -c
This restores the behavior as was documented in the server config docs, i.e. makes it possible to use
ISSO_SETTINGS=share/isso-dev.cfg isso run.This used to fail as
ISSO_SETTINGSwas only read by WSGI invocations ofisso.dispatchorisso.runPing @jwatt