Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[client] js: test/integration: Test API directly #884

Merged
merged 3 commits into from
May 25, 2022
Merged

[client] js: test/integration: Test API directly #884

merged 3 commits into from
May 25, 2022

Conversation

ix5
Copy link
Member

@ix5 ix5 commented May 25, 2022

Checklist

  • All new and existing tests are passing
  • (If adding features:) I have added tests to cover my changes
  • (If docs changes needed:) I have updated the documentation accordingly.
  • I have added an entry to CHANGES.rst because this is a user-facing change or an important bugfix
  • I have written proper commit message(s)

What changes does this Pull Request introduce?

  • js: test/integration: Test API directly
  • js: test: Add boilerplate jest-puppeteer conf
    Currently unused, but useful for quick debugging & adjustments during E2E testing.

Why is this necessary?

Improved test coverage

@ix5 ix5 added client (Javascript) client code and CSS improvement Not a new feature, but makes Isso more pleasant to use labels May 25, 2022
@ix5 ix5 added this to the 0.13 milestone May 25, 2022
@ix5 ix5 merged commit 9e6ec82 into isso-comments:master May 25, 2022
@ix5 ix5 deleted the js-jest-pptr-api branch May 25, 2022 04:34
@ix5 ix5 mentioned this pull request Jun 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
client (Javascript) client code and CSS improvement Not a new feature, but makes Isso more pleasant to use
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.
1 participant
@ix5