Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] [client] [docs] Fetch feed config from server, cleanup docs, isso-dev.cfg nits #898

Merged
merged 9 commits into from
Jun 4, 2022

Conversation

ix5
Copy link
Member

@ix5 ix5 commented Jun 4, 2022

Checklist

  • All new and existing tests are passing
  • (If adding features:) I have added tests to cover my changes
  • (If docs changes needed:) I have updated the documentation accordingly.
  • I have added an entry to CHANGES.rst because this is a user-facing change or an important bugfix
  • I have written proper commit message(s)

What changes does this Pull Request introduce?

views/comments, docs: Fetch feed config from server

Also: views: comments: Amend apiDoc of /config with new feed opt

conf, docs: Use true/false instead of on/off

The configparser accepts true/false, on/off and 1/0, but in order not to confuse users, unify on only true/false.

contrib: isso-dev.cfg: Enable/prepare more testing options

Also: js: test/integration: Update snapshot, reply-to-self enabled

docs: client-config: Document default values, cleanup

Also: js: config: Set default lang to null instead of empty string

docs: client-config: Use double backticks for code

Single backticks are only valid code markup in markdown. rST requires double backticks, else it'll render italics.

@ix5 ix5 added server (Python) server code client (Javascript) client code and CSS docs Documentation of the project improvement Not a new feature, but makes Isso more pleasant to use labels Jun 4, 2022
@ix5 ix5 added this to the 0.13 milestone Jun 4, 2022
@ix5 ix5 force-pushed the client-fetch-config-feed branch from 33a512a to d05a908 Compare June 4, 2022 18:08
@ix5 ix5 changed the title Client fetch config feed [server] [client] [docs] Fetch feed config from server, cleanup docs, isso-dev.cfg nits Jun 4, 2022
@ix5 ix5 merged commit aaa8476 into isso-comments:master Jun 4, 2022
@ix5 ix5 deleted the client-fetch-config-feed branch June 4, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client (Javascript) client code and CSS docs Documentation of the project improvement Not a new feature, but makes Isso more pleasant to use server (Python) server code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant