Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#23 #51

Conversation

WietseV
Copy link

@WietseV WietseV commented Jan 24, 2024

Css fix: set a minimum height to the button container. This will make sure the buttons always have enough space in the layout and will never be squashed behind other elements or components.

Css fix: set a minimum height to the button container.
@stoerr
Copy link
Member

stoerr commented Jan 25, 2024

Hi!
Thank you very much for testing the project and reporting a bug and even providing a PR! 😄

Am I guessing right that this is for the Side Panel AI action bar, that somehow gets too small in some cases, after longer texts are created?

If so: thank you for the nice fix! We'll have to change it a little because put like this the rule could have an effect anywhere, not just in the Composum AI, and I think it's important to have it stay light weight, so that it cannot change anything where the Composum AI isn't enabled. But I guess a

    #composumAI-sidebar-panel .betty-ActionBar {
        min-height: 48px;
    }

would do.

BTW: If you have some feedback about the Composum AI, I'm always eager to hear that!

@stoerr stoerr merged commit 99cf931 into ist-dresden:develop Jan 30, 2024
2 checks passed
@stoerr
Copy link
Member

stoerr commented Jan 30, 2024

Well, I'll merge it and add the additional selector in the develop branch later. Thank you for your contribution!

@WietseV
Copy link
Author

WietseV commented Jan 30, 2024

Hi,
Glad to help with the issue. The project looks really cool. @royteeuwen asked me to take a look at it and help if I could. You are right to assume it is a fix for the Side Panel AI Action bar that gets too small when the bar gets scrollable.

The addition of #composumAI-sidebar-panel is indeed a great fix to restrict it too the Composum AI.

sorry for the late answer.
Have a great day!

@stoerr
Copy link
Member

stoerr commented Jan 30, 2024

Thanks a lot! I admit I feel a little stupid not having seen that way of fixing that CSS problem. 😆 Though it's a bit strange that that happens in the first place.

@WietseV
Copy link
Author

WietseV commented Jan 30, 2024

Very strange indeed, no idea as why it happened in the first place, thought the solution should always cover it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants