Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#318 Browser Extension: Sling Context Aware Configuration #319

Merged
merged 45 commits into from
Feb 9, 2024
Merged

#318 Browser Extension: Sling Context Aware Configuration #319

merged 45 commits into from
Feb 9, 2024

Conversation

stoerr
Copy link
Member

@stoerr stoerr commented Feb 1, 2024 •
edited
Loading

This implements a basic version of #318 . The feature is described in detail in features/SlingContextAwareConfiguration.md .

Implementation idea:

  • on /content nodes the Sling-CA tab displays the effective configurations on that node, with links where the values are defined in the /conf hierarchy
  • depending on the location in the /conf//sling:configs//* hierarchy the new SlingCA tab displays either all configurations, a configuration collection or the individual values of a configuration.

Current limitations:

  • if there are properties of the configuration defined, like required, path root etc., these can be viewed (Icon P in a circle) but are currently not used.
  • inheritance is observed, but has to be edited in the properties tab.
  • nested configurations are not yet supported (e.g. property ConfigSampleSub[] sub() of a ConfigSampleNested)

@stoerr
very raw frame for initial caconfig view
f35f1a7
@stoerr
raw partial display of configuration
9e1d617
@stoerr
display collections as well
ec7b649
@stoerr
moving towards bootstrap design
fa45364
@stoerr
partial layout of single configurations
b640643
@stoerr
only show ca view where it is appropriate
2e34ab6
@stoerr
partial layout for collection configurations
b4643cf
@stoerr
dispatch views
7a8dd31
@stoerr
raw list
548b253
@stoerr
dependency fixes
c55c21a
@stoerr
bugfix: resize editor properly in groovy execution pane
bdd622e
@stoerr
browser: interpret properties that could be a path as path
ad6de05
@stoerr
continuing configuration views
fee824f
@stoerr
turn list configurations view into table
283bfb2
@stoerr
refactoring
2550149
@stoerr
JSP refactoring 2 - move toolbar into the files and introduce detail…
0ba24e9 
…-headline
@stoerr
continue
d7b79c4
@stoerr
fixes
d47114d
@stoerr
fix configuration view for single configurations
daf77f3
@stoerr
fix configuration view for collection configuration items
ca376de
@stoerr
add short form of data to collectionView.jsp
6ce76bf
@stoerr
link locations in eff conf view
37f5988
@stoerr
yaml object dumper for easy viewing object hierarchies
3a07870
@stoerr
how configuration inheritance
ed6c829
@stoerr
display collection inheritance in effectiveConfigurationsView.jsp
d3de848
@stoerr
insert data-path
f606f3f
@stoerr
fix listconfigurationsview
5e9de64
@stoerr
fix client library loading
0577b4b
@stoerr
functionality to create configuration nodes / configuration collecti…
49bf45f 
…on nodes
@stoerr
implement adding / deleting configurations from list
79e1feb
@stoerr stoerr requested a review from ist-rw February 1, 2024 18:09
@stoerr stoerr self-assigned this Feb 1, 2024
@stoerr stoerr linked an issue Feb 1, 2024 that may be closed by this pull request
Browser Extension: Sling Context Aware Configuration #318
Closed
@stoerr stoerr merged commit a1c1cc9 into develop Feb 9, 2024
2 checks passed
@stoerr stoerr deleted the feature/caconfigbrowser branch February 9, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ist-rw ist-rw Awaiting requested review from ist-rw

Assignees

@stoerr stoerr

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browser Extension: Sling Context Aware Configuration
1 participant
@stoerr