Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrade to babel 7, drop Node 4 support. #158

Merged
merged 1 commit into from
Jun 27, 2018
Merged

feat: Upgrade to babel 7, drop Node 4 support. #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .babelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"presets": ["env"],
"presets": ["@babel/env"],
"env": {
"test": {
"plugins": ["./lib"]
Expand Down
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ os:
after_success: npm run coverage

node_js:
- "4"
- "6"
- "8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using the following config recently to not have to worry about keeping this list up to date... however, we do technically support one LTS version back (v6, in this case). It would be nice if there was an alias for that but I don't know of one.

- "lts/*"
- "stable"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think testing of the oldest version we support is worth it, node.js major release cycle is long enough that adding new versions when needed isn't a big deal.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm with @coreyfarrell on this one, I like that it's more explicit.

- "stable"
Loading