docs: a bunch of updates to recent docs #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are from things that I didn't like in my original docs, the final straw being finding 'in in' in one of the lines. Hopefully this makes things better! Note I also added a change to the list of default `.nycrc` files to include `nyc.config.js`
AndrewFinlay
changed the title
JaKXz
reviewed
Mar 28, 2019
| @@ -298,7 +299,7 @@ modules should be required in the subprocess collecting coverage: | |||
|
|
|||
| ## Configuring `nyc` | |||
|
|
|||
| Any configuration options that can be set via the command line can also be specified in the `nyc` stanza of your package.json, or within a `.nycrc` (or `.nycrc.json`) file: | |||
| Any configuration options that can be set via the command line can also be specified in the `nyc` stanza of your package.json, or within a `.nycrc`, `.nycrc.json`, or `nyc.config.js` file: | |||
|
|
|||
| **package.json:** | |||
There was a problem hiding this comment.
could remove this line since we are saying this can go in multiple places...
and come to think of it, it would be really nice if this was actually just a table with the option names, valid input types and values, and a definition... That's a lot of work though so I will happily merge this PR without that!
|
This is awesome @AndrewFinlay [my comment is a nitpick that can be handled in a future PR] - I'll just let another set of eyes take a look before I merge. :) |
coreyfarrell
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are things that I didn't like in my original docs, the final straw being finding 'in in' in one of the lines. Hopefully this makes things better!
Note I also added a change to the list of default
.nycrcfiles to includenyc.config.js