Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use snapshots for spawn output testing #1133

Merged
merged 10 commits into from
Jun 20, 2019
Merged

chore: Use snapshots for spawn output testing #1133

merged 10 commits into from
Jun 20, 2019

Conversation

coreyfarrell
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jun 19, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 96.853% when pulling 64ff1a9 on coreyfarrell:test-snapshots into 914b776 on istanbuljs:master.

@coreyfarrell coreyfarrell requested review from bcoe and JaKXz June 20, 2019 10:30
@coreyfarrell
Copy link
Member Author

@bcoe @JaKXz this is necessary before I can update to the istanbuljs alpha deps. The issue is that the text report has changed and we have a ton of tests which test the output of that report. This way I'll be able to just regenerate the snapshots after upgrading and verify with git diff that formatting changed but data remained the same.

JaKXz
JaKXz approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 👍

@coreyfarrell coreyfarrell merged commit 4bc9c14 into istanbuljs:master Jun 20, 2019
@coreyfarrell coreyfarrell deleted the test-snapshots branch June 20, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaKXz JaKXz JaKXz approved these changes

@bcoe bcoe Awaiting requested review from bcoe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coreyfarrell @coveralls @JaKXz